Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
D
drupal
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Custom Issue Tracker
Custom Issue Tracker
Labels
Merge Requests
315
Merge Requests
315
Requirements
Requirements
List
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Analytics
Analytics
Code Review
Insights
Issue
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
project
drupal
Commits
a8a6638e
Unverified
Commit
a8a6638e
authored
Jun 13, 2020
by
alexpott
2
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue
#3139132
by Beakerboy, daffie: Query uses hardcoded LIMIT instead of queryRange()
parent
9eb7a173
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
1 deletion
+3
-1
core/modules/big_pipe/tests/src/Functional/BigPipeTest.php
core/modules/big_pipe/tests/src/Functional/BigPipeTest.php
+3
-1
No files found.
core/modules/big_pipe/tests/src/Functional/BigPipeTest.php
View file @
a8a6638e
...
...
@@ -192,7 +192,9 @@ public function testBigPipe() {
// Verify that the two expected exceptions are logged as errors.
$this
->
assertEqual
(
$log_count
+
2
,
$connection
->
query
(
'SELECT COUNT(*) FROM {watchdog}'
)
->
fetchField
(),
'Two new watchdog entries.'
);
$records
=
$connection
->
query
(
'SELECT * FROM {watchdog} ORDER BY wid DESC LIMIT 2'
)
->
fetchAll
();
// Using the method queryRange() allows contrib database drivers the ability
// to insert their own limit and offset functionality.
$records
=
$connection
->
queryRange
(
'SELECT * FROM {watchdog} ORDER BY wid DESC'
,
0
,
2
)
->
fetchAll
();
$this
->
assertEqual
(
RfcLogLevel
::
ERROR
,
$records
[
0
]
->
severity
);
$this
->
assertStringContainsString
(
'Oh noes!'
,
(
string
)
unserialize
(
$records
[
0
]
->
variables
)[
'@message'
]);
$this
->
assertEqual
(
RfcLogLevel
::
ERROR
,
$records
[
1
]
->
severity
);
...
...
alexpott
@alexpott
mentioned in commit
8b3b69fc
·
Jun 13, 2020
mentioned in commit
8b3b69fc
mentioned in commit 8b3b69fc0af7220d19b7d5b4648e7068c7adabac
Toggle commit list
alexpott
@alexpott
mentioned in commit
0f79223d
·
Jun 13, 2020
mentioned in commit
0f79223d
mentioned in commit 0f79223d36b36601ab929693726aaeff428c5b55
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment