Issue #3502664 by tom konda: Some of comparison with Node.nodeType uses magic number

core/misc/position.js

@@ -50,7 +50,7 @@
 
   function getDimensions(elem) {
     const raw = elem[0];
-    if (raw.nodeType === 9) {
+    if (raw.nodeType === Node.DOCUMENT_NODE) {
       return {
         width: elem.width(),
         height: elem.height(),
@@ -351,7 +351,8 @@
       const withinElement = $(element || window);
       const isWindow =
         !!withinElement[0] && withinElement[0] === withinElement[0].window;
-      const isDocument = !!withinElement[0] && withinElement[0].nodeType === 9;
+      const isDocument =
+        !!withinElement[0] && withinElement[0].nodeType === Node.DOCUMENT_NODE;
       const hasOffset = !isWindow && !isDocument;
       return {
         element: withinElement,

core/misc/tableselect.js

@@ -154,7 +154,7 @@
     for (let i = from[mode]; i; i = i[mode]) {
       const $i = $(i);
       // Make sure that we're only dealing with elements.
-      if (i.nodeType !== 1) {
+      if (i.nodeType !== Node.ELEMENT_NODE) {
         continue;
       }
       // Either add or remove the selected class based on the state of the