Issue #2896507 by heddn, maxocub: Update FieldPluginBase with a default...

Issue #2896507 by heddn, maxocub: Update FieldPluginBase with a default processFieldValues() and getFieldFormatterMap()

core/modules/datetime/src/Plugin/migrate/field/DateField.php

@@ -30,15 +30,6 @@ public function getFieldWidgetMap() {
     ];
   }
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    // See d6_field_formatter_settings.yml, d7_field_formatter_settings.yml and
-    // FieldPluginBase::processFieldFormatter().
-    return [];
-  }
-
   /**
    * {@inheritdoc}
    */

core/modules/datetime/src/Plugin/migrate/field/d6/DateField.php

@@ -35,15 +35,6 @@ public function getFieldWidgetMap() {
     ];
   }
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    // See d6_field_formatter_settings.yml and
-    // FieldPluginBase::processFieldFormatter().
-    return [];
-  }
-
   /**
    * {@inheritdoc}
    */

core/modules/file/src/Plugin/migrate/cckfield/d7/ImageField.php

@@ -13,13 +13,6 @@
  */
 class ImageField extends CckFieldPluginBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    return [];
-  }
-
   /**
    * {@inheritdoc}
    */

core/modules/migrate_drupal/src/Plugin/migrate/field/FieldPluginBase.php

@@ -45,6 +45,13 @@ public function processFieldWidget(MigrationInterface $migration) {
     $migration->mergeProcessOfProperty('options/type', $process);
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  public function getFieldFormatterMap() {
+    return [];
+  }
+
   /**
    * {@inheritdoc}
    */
@@ -66,6 +73,17 @@ public function processFieldFormatter(MigrationInterface $migration) {
     $migration->mergeProcessOfProperty('options/type', $process);
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  public function processFieldValues(MigrationInterface $migration, $field_name, $data) {
+    $process = [
+      'plugin' => 'get',
+      'source' => $field_name,
+    ];
+    $migration->mergeProcessOfProperty($field_name, $process);
+  }
+
   /**
    * {@inheritdoc}
    */

core/modules/migrate_drupal/src/Plugin/migrate/field/NodeReference.php

@@ -15,13 +15,6 @@
  */
 class NodeReference extends FieldPluginBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    return [];
-  }
-
   /**
    * {@inheritdoc}
    */

core/modules/migrate_drupal/src/Plugin/migrate/field/UserReference.php

@@ -15,13 +15,6 @@
  */
 class UserReference extends FieldPluginBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    return [];
-  }
-
   /**
    * {@inheritdoc}
    */

core/modules/migrate_drupal/tests/modules/migrate_cckfield_plugin_manager_test/src/Plugin/migrate/cckfield/D6FileField.php

@@ -16,11 +16,6 @@
  */
 class D6FileField extends CckFieldPluginBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {}
-
   /**
    * {@inheritdoc}
    */

core/modules/migrate_drupal/tests/modules/migrate_cckfield_plugin_manager_test/src/Plugin/migrate/cckfield/D6NoCoreVersionSpecified.php

@@ -12,11 +12,6 @@
  */
 class D6NoCoreVersionSpecified extends CckFieldPluginBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {}
-
   /**
    * {@inheritdoc}
    */

core/modules/migrate_drupal/tests/modules/migrate_field_plugin_manager_test/src/Plugin/migrate/cckfield/d6/FileField.php

@@ -13,13 +13,6 @@
  */
 class FileField extends CckFieldPluginBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    return [];
-  }
-
   /**
    * {@inheritdoc}
    */

core/modules/migrate_drupal/tests/modules/migrate_field_plugin_manager_test/src/Plugin/migrate/field/D6FileField.php

@@ -3,7 +3,6 @@
 namespace Drupal\migrate_field_plugin_manager_test\Plugin\migrate\field;
 
 use Drupal\migrate_drupal\Plugin\migrate\field\FieldPluginBase;
-use Drupal\migrate\Plugin\MigrationInterface;
 
 /**
  * @MigrateField(
@@ -14,18 +13,4 @@
  *   }
  * )
  */
-class D6FileField extends FieldPluginBase {
-
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    return [];
-  }
-
-  /**
-   * {@inheritdoc}
-   */
-  public function processFieldValues(MigrationInterface $migration, $field_name, $data) {}
-
-}
+class D6FileField extends FieldPluginBase {}

core/modules/migrate_drupal/tests/modules/migrate_field_plugin_manager_test/src/Plugin/migrate/field/D6NoCoreVersionSpecified.php

@@ -3,7 +3,6 @@
 namespace Drupal\migrate_field_plugin_manager_test\Plugin\migrate\field;
 
 use Drupal\migrate_drupal\Plugin\migrate\field\FieldPluginBase;
-use Drupal\migrate\Plugin\MigrationInterface;
 
 /**
  * @MigrateField(
@@ -12,16 +11,5 @@
  */
 class D6NoCoreVersionSpecified extends FieldPluginBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    return [];
-  }
-
-  /**
-   * {@inheritdoc}
-   */
-  public function processFieldValues(MigrationInterface $migration, $field_name, $data) {}
 
 }

core/modules/taxonomy/src/Plugin/migrate/cckfield/TaxonomyTermReference.php

@@ -16,13 +16,6 @@
  */
 class TaxonomyTermReference extends CckFieldPluginBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  public function getFieldFormatterMap() {
-    return [];
-  }
-
   /**
    * {@inheritdoc}
    */