Issue #3070604 by christinlepson, joachim, jhodgdon: badly named and...

Issue #3070604 by christinlepson, joachim, jhodgdon: badly named and documented parameter for FormBuilder::buildForm()

core/lib/Drupal/Core/Form/FormBuilder.php

@@ -221,9 +221,9 @@ public function getForm($form_arg) {
   /**
    * {@inheritdoc}
    */
-  public function buildForm($form_id, FormStateInterface &$form_state) {
+  public function buildForm($form_arg, FormStateInterface &$form_state) {
     // Ensure the form ID is prepared.
-    $form_id = $this->getFormId($form_id, $form_state);
+    $form_id = $this->getFormId($form_arg, $form_state);
 
     $request = $this->requestStack->getCurrentRequest();
 

core/lib/Drupal/Core/Form/FormBuilderInterface.php

@@ -68,7 +68,7 @@ public function getForm($form_arg);
    * previous page load. The form is then passed on for processing, validation,
    * and submission if there is proper input.
    *
-   * @param \Drupal\Core\Form\FormInterface|string $form_id
+   * @param \Drupal\Core\Form\FormInterface|string $form_arg
    *   The value must be one of the following:
    *   - The name of a class that implements \Drupal\Core\Form\FormInterface.
    *   - An instance of a class that implements \Drupal\Core\Form\FormInterface.
@@ -89,7 +89,7 @@ public function getForm($form_arg);
    *
    * @see self::redirectForm()
    */
-  public function buildForm($form_id, FormStateInterface &$form_state);
+  public function buildForm($form_arg, FormStateInterface &$form_state);
 
   /**
    * Constructs a new $form from the information in $form_state.