Issue #2318099 by tim.plunkett: Replace $form_state['complete_form'] with...

Issue #2318099 by tim.plunkett: Replace $form_state['complete_form'] with $form_state->getCompleteForm().

core/includes/batch.inc

@@ -388,7 +388,8 @@ function _batch_next_set() {
     if (isset($current_set['form_submit']) && ($callback = $current_set['form_submit']) && is_callable($callback)) {
       // We use our stored copies of $form and $form_state to account for
       // possible alterations by previous form submit handlers.
-      call_user_func_array($callback, array(&$batch['form_state']['complete_form'], &$batch['form_state']));
+      $complete_form = &$batch['form_state']->getCompleteForm();
+      call_user_func_array($callback, array(&$complete_form, &$batch['form_state']));
     }
     return TRUE;
   }

core/includes/form.inc

@@ -1792,7 +1792,7 @@ function form_process_machine_name($element, FormStateInterface $form_state) {
   // complete form in $form_state. By reference, because we may need to append
   // a #field_suffix that will hold the live preview.
   $key_exists = NULL;
-  $source = NestedArray::getValue($form_state['complete_form'], $element['#machine_name']['source'], $key_exists);
+  $source = NestedArray::getValue($form_state->getCompleteForm(), $element['#machine_name']['source'], $key_exists);
   if (!$key_exists) {
     return $element;
   }
@@ -1810,7 +1810,7 @@ function form_process_machine_name($element, FormStateInterface $form_state) {
     $source['#field_suffix'] = SafeMarkup::set($source['#field_suffix'] . ' <small id="' . $suffix_id . '">&nbsp;</small>');
 
     $parents = array_merge($element['#machine_name']['source'], array('#field_suffix'));
-    NestedArray::setValue($form_state['complete_form'], $parents, $source['#field_suffix']);
+    NestedArray::setValue($form_state->getCompleteForm(), $parents, $source['#field_suffix']);
   }
 
   $js_settings = array(

core/lib/Drupal/Core/Field/WidgetBase.php

@@ -382,7 +382,7 @@ public function flagErrors(FieldItemListInterface $items, ConstraintViolationLis
       $form_builder = \Drupal::formBuilder();
 
       // Locate the correct element in the the form.
-      $element = NestedArray::getValue($form_state['complete_form'], $field_state['array_parents']);
+      $element = NestedArray::getValue($form_state->getCompleteForm(), $field_state['array_parents']);
 
       // Do not report entity-level validation errors if Form API errors have
       // already been reported for the field.

core/lib/Drupal/Core/Form/FormBuilder.php

@@ -752,7 +752,8 @@ public function doBuildForm($form_id, &$element, FormStateInterface &$form_state
     // checkboxes and files.
     if (isset($element['#process']) && !$element['#processed']) {
       foreach ($element['#process'] as $process) {
-        $element = call_user_func_array($process, array(&$element, &$form_state, &$form_state['complete_form']));
+        $complete_form = &$form_state->getCompleteForm();
+        $element = call_user_func_array($process, array(&$element, &$form_state, &$complete_form));
       }
       $element['#processed'] = TRUE;
     }

core/lib/Drupal/Core/Form/FormValidator.php

@@ -251,7 +251,8 @@ protected function doValidateForm(&$elements, FormStateInterface &$form_state, $
       // #value data.
       elseif (isset($elements['#element_validate'])) {
         foreach ($elements['#element_validate'] as $callback) {
-          call_user_func_array($callback, array(&$elements, &$form_state, &$form_state['complete_form']));
+          $complete_form = &$form_state->getCompleteForm();
+          call_user_func_array($callback, array(&$elements, &$form_state, &$complete_form));
         }
       }
 

core/modules/responsive_image/src/ResponsiveImageMappingForm.php

@@ -106,7 +106,7 @@ public function validate(array $form, FormStateInterface $form_state) {
       $responsive_image_mapping->setMappings($form_state->getValue('mappings'));
 
       // Check if another breakpoint group is selected.
-      if ($form_state->getValue('breakpointGroup') != $form_state['complete_form']['breakpointGroup']['#default_value']) {
+      if ($form_state->getValue('breakpointGroup') != $form_state->getCompleteForm()['breakpointGroup']['#default_value']) {
         // Remove the mappings.
         $form_state->unsetValue('mappings');
       }

core/modules/user/user.module

@@ -485,8 +485,9 @@ function user_user_view(array &$build, UserInterface $account, EntityViewDisplay
  */
 function _user_language_selector_langcode_value($element, $input, FormStateInterface $form_state) {
   // Only add to the description if the form element have a description.
-  if (isset($form_state['complete_form']['language']['preferred_langcode']['#description'])) {
-    $form_state['complete_form']['language']['preferred_langcode']['#description'] .= ' ' . t("This is also assumed to be the primary language of this account's profile information.");
+  $complete_form = &$form_state->getCompleteForm();
+  if (isset($complete_form['language']['preferred_langcode']['#description'])) {
+    $complete_form['language']['preferred_langcode']['#description'] .= ' ' . t("This is also assumed to be the primary language of this account's profile information.");
   }
   return $form_state->getValue('preferred_langcode');
 }

core/modules/views_ui/admin.inc

@@ -129,7 +129,7 @@ function views_ui_add_limited_validation($element, FormStateInterface $form_stat
   $array_parents = $element['#array_parents'];
   array_pop($array_parents);
   $array_parents[] = $element['#views_ui_ajax_data']['trigger_key'];
-  $ajax_triggering_element = NestedArray::getValue($form_state['complete_form'], $array_parents);
+  $ajax_triggering_element = NestedArray::getValue($form_state->getCompleteForm(), $array_parents);
 
   // Limit this button's validation to the AJAX triggering element, so it can
   // update the form for that change without requiring that the rest of the
@@ -165,7 +165,7 @@ function views_ui_add_ajax_wrapper($element, FormStateInterface $form_state) {
   if (empty($element['#views_ui_ajax_data']['duplicate_wrapper'])) {
     // Find the region of the complete form that needs to be refreshed by AJAX.
     // This was earlier stored in a property on the element.
-    $complete_form = &$form_state['complete_form'];
+    $complete_form = &$form_state->getCompleteForm();
     $refresh_parents = $element['#views_ui_ajax_data']['refresh_parents'];
     $refresh_element = NestedArray::getValue($complete_form, $refresh_parents);