Skip to content
Snippets Groups Projects
Commit 8b7d64bd authored by catch's avatar catch
Browse files

Issue #3458975 by longwave, quietone:... 

Issue #3458975 by longwave, quietone: GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled fails on sqlite

(cherry picked from commit a878833e)
parent dd1cf47d
No related branches found
No related tags found
17 merge requests!10663Issue #3495778: Update phpdoc in FileSaveHtaccessLoggingTest,!10451Issue #3472458 by watergate, smustgrave: CKEditor 5 show blocks label is not translated,!103032838547 Fix punctuation rules for inline label suffix colon with CSS only,!10150Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change string...,!10130Resolve #3480321 "Second level menu",!9936Issue #3483087: Check the module:// prefix in the translation server path and replace it with the actual module path,!9933Issue #3394728 by ankondrat4: Undefined array key "#prefix" and deprecated function: explode() in Drupal\file\Element\ManagedFile::uploadAjaxCallback(),!9914Issue #3451136 by quietone, gapple, ghost of drupal past: Improve...,!9882Draft: Issue #3481777 In bulk_form ensure the triggering element is the bulk_form button,!9839Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9815Issue #3480025: There is no way to remove entity cache items,!9757Issue #3478869 Add "All" or overview links to parent links,!9752Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9749Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9678Issue #3465132 by catch, Spokje, nod_: Show test run time by class in run-tests.sh output,!9578Issue #3304746 by scott_euser, casey, smustgrave: BigPipe cannot handle (GET)...,!9449Issue #3344041: Allow textarea widgets to be used for text (formatted) fields
Pipeline #235957 passed with warnings
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#235973

    Pipeline: drupal

    #235967

      Pipeline: drupal

      #235959

        Hide whitespace changes
        Inline Side-by-side
        core/tests/Drupal/BuildTests/Command/GenerateThemeTest.php
        + 6
        − 9
        View file @ 8b7d64bd
        ...@@ -270,6 +270,7 @@ public function testContribStarterkitDevSnapshotWithGitNotInstalled(): void { ...@@ -270,6 +270,7 @@ public function testContribStarterkitDevSnapshotWithGitNotInstalled(): void {
        // not found. Note that we run our tests using process isolation, so we do // not found. Note that we run our tests using process isolation, so we do
        // not need to restore the PATH when we are done. // not need to restore the PATH when we are done.
        $unavailableGitPath = $this->getWorkspaceDirectory() . '/bin'; $unavailableGitPath = $this->getWorkspaceDirectory() . '/bin';
        putenv('PATH=' . $unavailableGitPath . ':' . getenv('PATH'));
        mkdir($unavailableGitPath); mkdir($unavailableGitPath);
        $bash = <<<SH $bash = <<<SH
        #!/bin/bash #!/bin/bash
        ...@@ -279,18 +280,14 @@ public function testContribStarterkitDevSnapshotWithGitNotInstalled(): void { ...@@ -279,18 +280,14 @@ public function testContribStarterkitDevSnapshotWithGitNotInstalled(): void {
        file_put_contents($unavailableGitPath . '/git', $bash); file_put_contents($unavailableGitPath . '/git', $bash);
        chmod($unavailableGitPath . '/git', 0755); chmod($unavailableGitPath . '/git', 0755);
        // Confirm that 'git' is no longer available. // Confirm that 'git' is no longer available.
        $env = [ $process = new Process(['git', '--help']);
        'PATH' => $unavailableGitPath . ':' . getenv('PATH'),
        'COLUMNS' => 80,
        ];
        $process = new Process([
        'git',
        '--help',
        ], NULL, $env);
        $process->run(); $process->run();
        $this->assertEquals(127, $process->getExitCode(), 'Fake git used by process.'); $this->assertEquals(127, $process->getExitCode(), 'Fake git used by process.');
        $process = $this->generateThemeFromStarterkit($env); $process = $this->generateThemeFromStarterkit([
        'PATH' => getenv('PATH'),
        'COLUMNS' => 80,
        ]);
        $result = $process->run(); $result = $process->run();
        $this->assertEquals("[ERROR] The source theme starterkit_theme has a development version number \n (7.x-dev). Determining a specific commit is not possible because git is\n not installed. Either install git or use a tagged release to generate a\n theme.", trim($process->getErrorOutput()), $process->getErrorOutput()); $this->assertEquals("[ERROR] The source theme starterkit_theme has a development version number \n (7.x-dev). Determining a specific commit is not possible because git is\n not installed. Either install git or use a tagged release to generate a\n theme.", trim($process->getErrorOutput()), $process->getErrorOutput());
        $this->assertSame(1, $result); $this->assertSame(1, $result);
        ......
        0% or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Finish editing this message first!
        Please register or to comment