Skip to content

GitLab

Commit 89b2069e authored by Dries's avatar Dries
Browse files 

- Clean URL patch.
parent 97858f9b
Hide whitespace changes
Inline Side-by-side
admin.php deleted 100644 → 0
View file @ 97858f9b
<?php
// $Id$
include_once "includes/common.inc";
function status($message) {
if ($message) {
return "<b>Status:</b> $message<hr />\n";
}
}
function admin_page($mod) {
global $user;
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "DTD/xhtml1-transitional.dtd">
<html>
<head>
<title><?php echo variable_get("site_name", "drupal") . " " . t("administration pages"); ?></title>
<link rel="stylesheet" type="text/css" media="print" href="misc/print.css" />
<style type="text/css" title="layout" media="Screen">
@import url("misc/admin.css");
</style>
</head>
<body>
<?php
// NOTE: we include a dummy "print.css" to remove the "flash of unstyled content" (FUOC) problems in IE.
module_invoke_all("link", "admin");
/*
** Menu:
*/
print "<div id=\"menu\">";
echo "<h1><a href=\"index.php\">". variable_get("site_name", "drupal") ."</a></h1>";
print menu_tree() ;
print "</div>";
/*
** Body:
*/
print "<a href=\"http://drupal.org/\"><img align=\"right\" src=\"misc/druplicon-small.gif\" alt=\"Druplicon - Drupal logo\" border=\"0\" /></a>";
print "<div id=\"main\">";
if ($path = menu_path()) {
print "<h2>". la(t("Administration")) ." &gt; $path</h2>";
}
else {
print "<h2>". t("Administration") ."</h2>";
}
if ($menu = menu_menu()) {
print "$menu<br />";
}
print "<br /><hr /><br />";
if ($help = menu_help()) {
print "<small>$help</small><br /><br />";
}
if ($mod) {
print module_invoke($mod, "admin");
}
else {
print watchdog_overview("actions");
}
print "</div>";
db_query("DELETE FROM menu");
?>
</body>
</html>
<?php
}
if (user_access("access administration pages")) {
page_header();
admin_page($mod);
page_footer();
}
else {
print message_access();
}
?>
includes/common.inc
View file @ 89b2069e
......@@ -2,7 +2,7 @@
// $Id$
function conf_init() {
global $HTTP_HOST;
global $HTTP_HOST, $PHP_SELF;
/*
** Try finding a matching configuration file by stripping the website's
......@@ -10,7 +10,9 @@ function conf_init() {
** default value 'conf'.
*/
$file = strtolower(strtr($HTTP_HOST . substr(request_uri(), 0, strrpos(request_uri(), "/")), "/:", ".."));
$uri = $PHP_SELF;
$file = strtolower(strtr($HTTP_HOST . substr($uri, 0, strrpos($uri, "/")), "/:", ".."));
while (strlen($file) > 4) {
if (file_exists("includes/$file.php")) {
......@@ -35,7 +37,7 @@ function error_handler($errno, $message, $filename, $line, $variables) {
function watchdog($type, $message, $link = NULL) {
global $user;
db_query("INSERT INTO watchdog (uid, type, message, link, location, hostname, timestamp) VALUES ('$user->uid', '%s', '%s', '%s', '%s', '%s', '%s')", $type, $message, $link, request_uri(), getenv("REMOTE_ADDR"), time());
db_query("INSERT INTO watchdog (uid, type, message, link, location, hostname, timestamp) VALUES ('$user->uid', '%s', '%s', '%s', '%s', '%s', '%s')", $type, $message, $link, $uri, getenv("REMOTE_ADDR"), time());
}
function throttle($type, $rate) {
......@@ -56,6 +58,18 @@ function check_php_setting($name, $value) {
}
}
function arg($index) {
global $q;
static $arguments;
if (empty($arguments)) {
$arguments = explode("/", $q);
}
return $arguments[$index];
}
function array2object($node) {
if (is_array($node)) {
......@@ -85,8 +99,11 @@ function object2array($node) {
}
function path_uri($brief = 0) {
global $HTTP_HOST;
$path = $HTTP_HOST . substr(request_uri(), 0, strrpos(request_uri(), "/")) ."/";
global $HTTP_HOST, $PHP_SELF;
$uri = $PHP_SELF;
$path = $HTTP_HOST . substr($uri, 0, strrpos($uri, "/")) ."/";
if (!$brief) {
$path = "http://". $path;
}
......@@ -133,9 +150,8 @@ function t($string, $args = 0) {
** translation string is for example:
**
** $msg = t("You must login below or <a href=\"%url\">create a new
** account</a> before viewing the next page.", array ("%url"
** => drupal_url(array ("mod" => "user", "op" => "register"),
** "module")));
** account</a> before viewing the next page.", array("%url"
** => url("user/register")));
*/
$string = ($languages && function_exists("locale") ? locale($string) : $string);
......@@ -277,12 +293,12 @@ function search_item($item, $type) {
* Render a generic search form.
*
* "Generic" means "universal usable" - that is, usable not only from
* module.php?mod=search, but also as a simple seach box (without
* 'site.com/search', but also as a simple seach box (without
* "Restrict search to", help text, etc) from theme's header etc.
* This means: provide options to only conditionally render certain
* parts of this form.
*
* @param $action Form action. Defaults to module.php?mod=search.
* @param $action Form action. Defaults to 'site.com/search'.
* @param $query Query string. Defaults to global $keys.
* @param $options != 0: Render additional form fields/text
* ("Restrict search to", help text, etc).
......@@ -291,7 +307,7 @@ function search_form($action = 0, $query = 0, $options = 0) {
global $keys;
if (!$action) {
$action = drupal_url(array("mod" => "search"), "module");
$action = url("search");
}
if (!$query) {
......@@ -310,8 +326,6 @@ function search_form($action = 0, $query = 0, $options = 0) {
$output .= " <input type=\"checkbox\" name=\"edit[type][$name]\" ". ($edit["type"][$name] ? " checked=\"checked\"" : "") ." /> ". t($name);
}
}
// TODO: (link to) search hints
}
$form .= "<br />";
......@@ -354,7 +368,7 @@ function search_data() {
*
* @param $type If set, search only nodes of this type.
* Otherwise, search all types.
* @param $action Form action. Defaults to module.php?mod=search.
* @param $action Form action. Defaults to 'site.com/search'.
* @param $query Query string. Defaults to global $keys.
* @param $options != 0: Render additional form fields/text
* ("Restrict search to", help text, etc).
......@@ -638,11 +652,11 @@ function format_name($object) {
global $PHP_SELF;
if ($object->uid && $object->name) {
if (strstr($PHP_SELF, "admin.php")) {
$output = la($object->name, array("mod" => "user", "op" => "edit", "id" => $object->uid), "", array("title" => t("Administer user profile.")));
if (strstr($PHP_SELF, "admin")) {
$output = l($object->name, "admin/user/edit/$object->uid", array("title" => t("Administer user profile.")));
}
else {
$output = lm($object->name, array("mod" => "user", "op" => "view", "id" => $object->uid), "", array("title" => t("View user profile.")));
$output = l($object->name, "user/view/$object->uid", array("title" => t("View user profile.")));
}
}
else {
......@@ -652,10 +666,6 @@ function format_name($object) {
return $output;
}
function format_tag($link, $text) {
return l(($text ? $text : $link), array("title" => $link));
}
function form($form, $method = "post", $action = 0, $options = 0) {
return "<form action=\"". ($action ? $action : htmlentities(request_uri())) ."\" method=\"$method\"". ($options ? " $options" : "") .">\n$form</form>\n";
}
......@@ -737,72 +747,22 @@ function drupal_parse_url($url = NULL) {
return $cache[$url];
}
/**
* Build an URL; use this functions when you must write an URL
* for example in a form or a redirect.
*
* @param $args dictionary of arguments to be passed to the script
* @param $script script to be invoked; optional, defaults to node
* @param $anchor optional, anchor name
*/
function drupal_url($args = array(), $script = "node", $anchor = 0) {
static $search, $replace;
if (!$search) {
/*
According to RFC 1738 [3] the special characters "$-_.+!*'()," and the
reserved characters "/:@#?&=" can be used unencoded within an URL
*/
$search = array("%24", "%2B", "%21", "%2A", "%27", "%28", "%29", "%2C", "%2F", "%3A", "%40", "%23", "%3F", "%26", "%3D");
$replace = array("$", "+", "!", "*", "'", "(", ")", ",", "/", ":", "@", "#", "?", "&", "=");
}
$t = array();
foreach ($args as $key => $value) {
$t[] = "$key=". str_replace($search, $replace, urlencode($value));
}
if (count($t)) {
return "$script.php?". implode("&amp;", $t) . ($anchor ? "#$anchor" : "");
}
else {
return "$script.php". ($anchor ? "#$anchor" : "");
}
function url($url, $query = NULL) {
return "?q=$url". ($query ? "&$query" : "");
}
/**
* Build a HTML link; use this functions when you must write a link
* to another drupal page
*
* @param $args dictionary of arguments to be passed to the script
* @param $text text of the link
* @param $anchor optional, anchor name
* @param $script script to be invoked; optional, defaults to node
* @param $attributes optional, dictionary of attributes for the <a> tag such as 'target', 'name', 'class', etc.
*/
function l($text, $args = array(), $script = "node", $anchor = "", $attributes = array()) {
$t = array();
foreach ($attributes as $key => $value) {
$t[] = "$key=\"$value\"";
}
return "<a href=\"". drupal_url($args, $script, $anchor) ."\" ". implode($t, " ") .">$text</a>";
}
function l($text, $url, $attributes = array(), $query = NULL) {
function la($text, $args = array(), $anchor = "", $attributes = array()) {
// we don't call l() to avoid another duplication of the array
$t = array();
foreach ($attributes as $key => $value) {
$t[] = "$key=\"$value\"";
if (!is_array($attributes)) {
print "$text - $url";
}
return "<a href=\"". drupal_url($args, "admin", $anchor) ."\" ". implode($t, " ") .">$text</a>";
}
function lm($text, $args = array(), $anchor = "", $attributes = array()) {
// we don't call l() to avoid another duplication of the array
$t = array();
foreach ($attributes as $key => $value) {
$t[] = "$key=\"$value\"";
}
return "<a href=\"". drupal_url($args, "module", $anchor) ."\" ". implode($t, " ") .">$text</a>";
return "<a href=\"". url($url, $query) ."\" ". implode($t, " ") .">$text</a>";
}
function field_get($string, $name) {
......@@ -825,7 +785,7 @@ function link_page() {
return $custom_links;
}
else {
$links[] = l(t("home"), array(), "index", "", array("title" => t("Return to the main page.")));
$links[] = "<a href=\"index.php\" title=\"". t("Return to the main page.") ."\">". t("home") ."</a>";
foreach (module_list() as $name) {
if (module_hook($name, "link")) {
$links = array_merge($links, module_invoke($name, "link", "page"));
......
includes/conf.php
View file @ 89b2069e
......@@ -45,8 +45,7 @@
# top of every page.
// $custom_links = array(
// "<a href=\"index.php\">home</a>",
// "<a href=\"module.php?mod=user\">school</a>",
// "<a href=\"module.php?mod=blog\">work</a>");
// "<a href=\"blog\">journal</a>",
// "<a href=\"story\">articles</a>");
?>
includes/menu.inc
View file @ 89b2069e
......@@ -2,7 +2,7 @@
function menu_trail() {
global $REQUEST_URI;
global $QUERY_STRING;
static $trail = NULL;
/*
......@@ -12,8 +12,7 @@ function menu_trail() {
if (empty($trail)) {
$path = array();
$link = substr($REQUEST_URI, strrpos($REQUEST_URI, "/") + 1, strlen($REQUEST_URI));
$item = db_fetch_object(db_query("SELECT * FROM menu WHERE link = '%s'", $link));
$item = db_fetch_object(db_query("SELECT * FROM menu WHERE link LIKE '%%%s'", $QUERY_STRING));
/*
** Compile an array of menu objects that represent the path to
......@@ -38,14 +37,13 @@ function menu_trail() {
}
function menu_item($item) {
global $REQUEST_URI;
/*
** If you want to theme your links, or if you want to replace them
** by an image, this would be the function to customize.
*/
if (stristr($REQUEST_URI, $item->link) == $item->link) {
if (stristr(request_uri(), $item->link) == $item->link) {
return t($item->name);
}
else if ($item->title) {
......
includes/module.inc
View file @ 89b2069e
......@@ -4,6 +4,7 @@
// initialize modules:
function module_init() {
// Note: changing this also requires changing system_admin() @ modules/system.module.
require_once "modules/admin.module";
require_once "modules/user.module";
require_once "modules/system.module";
require_once "modules/watchdog.module";
......
includes/pager.inc
View file @ 89b2069e
......@@ -295,7 +295,8 @@ function pager_link($from_new, $attributes = array()) {
$url["query"] = array_merge($url["query"], $attributes);
}
return drupal_url($url["query"], $url["script"]);
// TODO: should use 'url()':
// return drupal_url($url["query"], $url["script"]);
}
function pager_load_array($value, $element, $old_array) {
......
index.php
View file @ 89b2069e
......@@ -3,19 +3,34 @@
include_once "includes/common.inc";
page_header();
check_php_setting("magic_quotes_gpc", 0);
check_php_setting("register_globals", 1);
if ($q) {
$mod = arg(0);
}
if (module_hook(variable_get("site_frontpage", "node"), "page")) {
module_invoke(variable_get("site_frontpage", "node"), "page");
if ($mod && module_hook($mod, "page")) {
if ($mod != "admin") {
page_header();
}
module_invoke($mod, "page");
if ($mod != "admin") {
page_footer();
}
}
else {
$theme->header();
$theme->footer();
}
page_header();
page_footer();
check_php_setting("magic_quotes_gpc", 0);
check_php_setting("register_globals", 1);
if (module_hook(variable_get("site_frontpage", "node"), "page")) {
module_invoke(variable_get("site_frontpage", "node"), "page");
}
else {
$theme->header();
$theme->footer();
}
page_footer();
}
?>
module.php deleted 100644 → 0
View file @ 97858f9b
<?php
// $Id$
include_once "includes/common.inc";
if (module_hook($mod, "page")) {
page_header();
module_invoke($mod, "page");
page_footer();
}
else {
header("Location: index.php");
}
?>
modules/admin.module 0 → 100644
View file @ 89b2069e
<?php
// $Id$
include_once "includes/common.inc";
function status($message) {
if ($message) {
return "<b>Status:</b> $message<hr />\n";
}
}
function admin_page($mod) {
global $user;
if (user_access("access administration pages")) {
page_header();
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "DTD/xhtml1-transitional.dtd">
<html>
<head>
<title><?php echo variable_get("site_name", "drupal") . " " . t("administration pages"); ?></title>
<link rel="stylesheet" type="text/css" media="print" href="misc/print.css" />
<style type="text/css" title="layout" media="Screen">
@import url("misc/admin.css");
</style>
</head>
<body>
<?php
// NOTE: we include a dummy "print.css" to remove the "flash of unstyled content" (FUOC) problems in IE.
module_invoke_all("link", "admin");
/*
** Menu:
*/
print "<div id=\"menu\">";
echo "<h1><a href=\"index.php\">". variable_get("site_name", "drupal") ."</a></h1>";
print menu_tree() ;
print "</div>";
/*
** Body:
*/
print "<a href=\"http://drupal.org/\"><img align=\"right\" src=\"misc/druplicon-small.gif\" alt=\"Druplicon - Drupal logo\" border=\"0\" /></a>";
print "<div id=\"main\">";
if ($path = menu_path()) {
print "<h2>". l(t("Administration"), "admin") ." &gt; $path</h2>";
}
else {
print "<h2>". t("Administration") ."</h2>";
}
if ($menu = menu_menu()) {
print "$menu<br />";
}
print "<br /><hr /><br />";
if ($help = menu_help()) {
print "<small>$help</small><br /><br />";
}
if (arg(1)) {
print module_invoke(arg(1), "admin");
}
else {
print watchdog_overview("actions");
}
print "</div>";
db_query("DELETE FROM menu");
?>
</body>
</html>
<?php
page_footer();
}
else {
print message_access();
}
}
?>
modules/aggregator.module
View file @ 89b2069e
......@@ -31,15 +31,15 @@ function import_perm() {
function import_link($type) {
if ($type == "page" && user_access("access news feeds")) {
$links[] = lm(t("news feeds"), array("mod" => "import"), "", array("title" => t("Read the latest news from syndicated websites.")));
$links[] = l(t("news feeds"), "import", array("title" => t("Read the latest news from syndicated websites.")));
}
if ($type == "admin" && user_access("administer news feeds")) {
menu_add("news aggregation", "admin.php?mod=import", "Content syndication through RDF/RSS feeds.", NULL, NULL, 3);
menu_add("add new feed", "admin.php?mod=import&op=add&type=feed", "Add new news feed.", NULL, "news aggregation", 2);
menu_add("add new bundle", "admin.php?mod=import&op=add&type=bundle", "Create a new bundle.", NULL, "news aggregation", 3);
menu_add("tag news items", "admin.php?mod=import&op=tag", "Assign bundle attributes to a news item.", NULL, "news aggregation", 4);
menu_add("help", "admin.php?mod=import&op=help", "More information about news aggregation.", NULL, "news aggregation", 5);
menu_add("news aggregation", url("admin/import"), "Content syndication through RDF/RSS feeds.", NULL, NULL, 3);
menu_add("add new feed", url("admin/import/add/feed"), "Add new news feed.", NULL, "news aggregation", 2);
menu_add("add new bundle", url("admin/import/add/bundle"), "Create a new bundle.", NULL, "news aggregation", 3);
menu_add("tag news items", url("admin/import/tag"), "Assign bundle attributes to a news item.", NULL, "news aggregation", 4);
menu_add("help", url("admin/import/help"), "More information about news aggregation.", NULL, "news aggregation", 5);
}
return $links ? $links : array();
......@@ -63,7 +63,7 @@ function import_format_item($item, $feed = 0) {
global $theme, $user;
if ($user->uid && user_access("maintain personal blog")) {
$output .= lm("<img src=\"". $theme->image("blog.gif") ."\" border=\"0\" width=\"12\" height=\"16\" alt=\"". t("Blog this item") ."\" />", array("mod" => "node", "op" => "add", "type" => "blog", "iid" => $item->iid), "", array("title" => t("Comment on this news item in your personal blog.")));
$output .= l("<img src=\"". $theme->image("blog.gif") ."\" border=\"0\" width=\"12\" height=\"16\" alt=\"". t("Blog this item") ."\" />", "node/add/blog&iid=$item->iid", array("title" => t("Comment on this news item in your personal blog.")));
}
// external link
......@@ -116,13 +116,13 @@ function import_block($op, $delta) {
$feed = db_fetch_object(db_query("SELECT * FROM feed WHERE fid = '%d'", $delta));
if ($feed) {
$block["subject"] = $feed->title;
$block["content"] = import_feed_block($feed) ."<p><div align=\"right\">". lm(t("more"), array("mod" => "import", "op" => "feed", "id" => $feed->fid), "", array("title" => t("View this feed's recent news."))) ."</div></p>";
$block["content"] = import_feed_block($feed) ."<p><div align=\"right\">". l(t("more"), "import/feed/$feed->fid", array("title" => t("View this feed's recent news."))) ."</div></p>";
}
else {
// it was a bundle. this is NOT elegant
$bundle = db_fetch_object(db_query("SELECT * FROM bundle WHERE bid = '%d'", $delta));
$block["subject"] = $bundle->title;
$block["content"] = import_bundle_block($bundle->attributes) ."<p><div align=\"right\">". lm(t("more"), array("mod" => "import", "op" => "bundle", "id" => $bundle->bid), "", array("title" => t("View this bundle's recent news."))) ."</div></p>";
$block["content"] = import_bundle_block($bundle->attributes) ."<p><div align=\"right\">". l(t("more"), "import/bundle/$bundle->bid", array("title" => t("View this bundle's recent news."))) ."</div></p>";
}
return $block;
......@@ -136,7 +136,7 @@ function import_get_bundles($attributes = 0) {
$result = db_query("SELECT * FROM bundle ORDER BY title");
while ($bundle = db_fetch_object($result)) {
$block[$bundle->bid]["subject"] = $bundle->title;
$block[$bundle->bid]["content"] = import_bundle_block($bundle->attributes) ."<p><div align=\"right\">". lm(t("more"), array("mod" => "import", "op" => "bundle", "id" => $bundle->bid), "", array("title" => t("View this bundle's recent news."))) ."</div></p>";
$block[$bundle->bid]["content"] = import_bundle_block($bundle->attributes) ."<p><div align=\"right\">". l(t("more"), "import/bundle/$bundle->bid", array("title" => t("View this bundle's recent news."))) ."</div></p>";
$block[$bundle->bid]["info"] = "$bundle->title bundle";
}
......@@ -150,7 +150,7 @@ function import_get_feeds($attributes = 0) {
$result = db_query("SELECT * FROM feed ORDER BY fid");
while ($feed = db_fetch_object($result)) {
$block[$feed->fid]["subject"] = $feed->title;
$block[$feed->fid]["content"] = import_feed_block($feed) ."<p><div align=\"right\">". lm(t("more"), array("mod" => "import", "op" => "feed", "id" => $feed->fid), "", array("title" => t("View this feed's recent news."))) ."</div></p>";
$block[$feed->fid]["content"] = import_feed_block($feed) ."<p><div align=\"right\">". l(t("more"), "import/feed/$feed->fid", array("title" => t("View this feed's recent news."))) ."</div></p>";
$block[$feed->fid]["info"] = "$feed->title feed";
}
......@@ -387,7 +387,7 @@ function import_view() {
$header = array(t("title"), t("attributes"), t("items"), t("last update"), t("next update"), array("data" => t("operations"), "colspan" => 3));
unset($rows);
while ($feed = db_fetch_object($result)) {
$rows[] = array($feed->title, $feed->attributes, format_plural($feed->items, "item", "items"), ($feed->timestamp ? format_interval(time() - $feed->timestamp) ." ago" : "never"), ($feed->timestamp ? format_interval($feed->timestamp + $feed->refresh - time()) ." left" : "never"), la(t("edit feed"), array("mod" => "import", "type" => "feed", "op" => "edit", "id" => $feed->fid)), la(t("remove items"), array("mod" => "import", "type" => "feed", "op" => "remove", "id" => $feed->fid)), la(t("update items"), array("mod" => "import", "type" => "feed", "op" => "update", "id" => $feed->fid)));
$rows[] = array($feed->title, $feed->attributes, format_plural($feed->items, "item", "items"), ($feed->timestamp ? format_interval(time() - $feed->timestamp) ." ago" : "never"), ($feed->timestamp ? format_interval($feed->timestamp + $feed->refresh - time()) ." left" : "never"), l(t("edit feed"), "admin/import/edit/feed/$feed->fid"), l(t("remove items"), "admin/import/remove/$feed->fid"), l(t("update items"), "admin/import/update/$feed->fid"));
}
$output .= table($header, $rows);