Issue #2459289 by Lendude, dhrjgpt2005, kalistos, dawehner, david_garcia:...

Issue #2459289 by Lendude, dhrjgpt2005, kalistos, dawehner, david_garcia: Boolean default values are not saved

core/modules/action/tests/action_bulk_test/config/install/views.view.test_bulk_form.yml

@@ -132,7 +132,7 @@ display:
           entity_type: node
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/book/tests/modules/book_test_views/test_views/views.view.test_book_view.yml

@@ -854,7 +854,7 @@ display:
           plugin_id: field
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           plugin_id: boolean

core/modules/comment/config/optional/views.view.comments_recent.yml

@@ -173,7 +173,7 @@ display:
           entity_field: changed
       filters:
         status:
-          value: true
+          value: '1'
           table: comment_field_data
           field: status
           id: status
@@ -184,7 +184,7 @@ display:
           entity_type: comment
           entity_field: status
         status_node:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           relationship: node

core/modules/comment/tests/modules/comment_test_views/test_views/views.view.test_comment_row.yml

@@ -120,7 +120,7 @@ display:
           entity_field: subject
       filters:
         status:
-          value: true
+          value: '1'
           table: comment_field_data
           field: status
           id: status
@@ -131,7 +131,7 @@ display:
           entity_type: comment
           entity_field: status
         status_node:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           relationship: node

core/modules/contact/tests/modules/contact_test_views/test_views/views.view.test_contact_link.yml

@@ -111,7 +111,7 @@ display:
           entity_type: user
       filters:
         status:
-          value: true
+          value: '1'
           table: users_field_data
           field: status
           id: status

core/modules/field/src/Tests/Views/FieldUITest.php

@@ -146,6 +146,16 @@ public function testBooleanFilterHandler() {
     $this->assertEqual(t('True'), (string) $option[0]);
     $option = $this->xpath('//label[@for="edit-options-value-0"]');
     $this->assertEqual(t('False'), (string) $option[0]);
+
+    // Expose the filter and see if the 'Any' option is added and if we can save
+    // it.
+    $this->drupalPostForm(NULL, [], 'Expose filter');
+    $option = $this->xpath('//label[@for="edit-options-value-all"]');
+    $this->assertEqual(t('- Any -'), (string) $option[0]);
+    $this->drupalPostForm(NULL, ['options[value]' => 'All', 'options[expose][required]' => FALSE], 'Apply');
+    $this->drupalPostForm(NULL, [], 'Save');
+    $this->drupalGet('/admin/structure/views/nojs/handler/test_view_fieldapi/default/filter/field_boolean_value');
+    $this->assertFieldChecked('edit-options-value-all');
   }
 
 }

core/modules/link/tests/modules/link_test_views/test_views/views.view.test_link_tokens.yml

@@ -147,7 +147,7 @@ display:
           plugin_id: field
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           plugin_id: boolean

core/modules/node/config/optional/views.view.archive.yml

@@ -106,7 +106,7 @@ display:
           id: status
           table: node_field_data
           field: status
-          value: true
+          value: '1'
           group: 0
           expose:
             operator: '0'

core/modules/node/config/optional/views.view.content.yml

@@ -370,7 +370,7 @@ display:
           group_type: group
           admin_label: ''
           operator: '='
-          value: true
+          value: '1'
           group: 1
           exposed: true
           expose:

core/modules/node/config/optional/views.view.frontpage.yml

@@ -105,7 +105,7 @@ display:
           operator: '='
           relationship: none
           table: node_field_data
-          value: true
+          value: '1'
           plugin_id: boolean
           entity_type: node
           entity_field: promote
@@ -116,7 +116,7 @@ display:
           group: 1
           id: status
           table: node_field_data
-          value: true
+          value: '1'
           plugin_id: boolean
           entity_type: node
           entity_field: status

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_field_filters.yml

@@ -91,7 +91,7 @@ display:
           plugin_id: field
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status
@@ -177,7 +177,7 @@ display:
         filter_groups: false
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status
@@ -244,7 +244,7 @@ display:
         filter_groups: false
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status
@@ -311,7 +311,7 @@ display:
         filter_groups: false
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_language.yml

@@ -166,7 +166,7 @@ display:
           type: language
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_path_plugin.yml

@@ -123,7 +123,7 @@ display:
           plugin_id: node_path
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           plugin_id: boolean

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_row_plugin.yml

@@ -29,7 +29,7 @@ display:
           group: 1
           id: status
           table: node_field_data
-          value: true
+          value: '1'
           plugin_id: boolean
           entity_type: node
           entity_field: status

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_view.yml

@@ -123,7 +123,7 @@ display:
           entity_field: nid
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/options/tests/options_test_views/test_views/views.view.test_options_list_argument_numeric.yml

@@ -89,7 +89,7 @@ display:
           plugin_id: field
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/options/tests/options_test_views/test_views/views.view.test_options_list_argument_string.yml

@@ -89,7 +89,7 @@ display:
           plugin_id: field
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/options/tests/options_test_views/test_views/views.view.test_options_list_filter.yml

@@ -89,7 +89,7 @@ display:
           plugin_id: field
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/statistics/tests/modules/statistics_test_views/test_views/views.view.test_statistics_integration.yml

@@ -223,7 +223,7 @@ display:
           plugin_id: numeric
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/system/src/Tests/Update/UpdatePathTestBase.php

@@ -250,27 +250,28 @@ protected function runUpdates() {
     // Ensure there are no failed updates.
     if ($this->checkFailedUpdates) {
       $this->assertNoRaw('<strong>' . t('Failed:') . '</strong>');
-    }
 
-    // The config schema can be incorrect while the update functions are being
-    // executed. But once the update has been completed, it needs to be valid
-    // again. Assert the schema of all configuration objects now.
-    $names = $this->container->get('config.storage')->listAll();
-    /** @var \Drupal\Core\Config\TypedConfigManagerInterface $typed_config */
-    $typed_config = $this->container->get('config.typed');
-    $typed_config->clearCachedDefinitions();
-    foreach ($names as $name) {
-      $config = $this->config($name);
-      $this->assertConfigSchema($typed_config, $name, $config->get());
-    }
+      // The config schema can be incorrect while the update functions are being
+      // executed. But once the update has been completed, it needs to be valid
+      // again. Assert the schema of all configuration objects now.
+      $names = $this->container->get('config.storage')->listAll();
+      /** @var \Drupal\Core\Config\TypedConfigManagerInterface $typed_config */
+      $typed_config = $this->container->get('config.typed');
+      $typed_config->clearCachedDefinitions();
+      foreach ($names as $name) {
+        $config = $this->config($name);
+        $this->assertConfigSchema($typed_config, $name, $config->get());
+      }
 
-    // Ensure that the update hooks updated all entity schema.
-    $needs_updates = \Drupal::entityDefinitionUpdateManager()->needsUpdates();
-    $this->assertFalse($needs_updates, 'After all updates ran, entity schema is up to date.');
-    if ($needs_updates) {
-      foreach (\Drupal::entityDefinitionUpdateManager()->getChangeSummary() as $entity_type_id => $summary) {
-        foreach ($summary as $message) {
-          $this->fail($message);
+      // Ensure that the update hooks updated all entity schema.
+      $needs_updates = \Drupal::entityDefinitionUpdateManager()->needsUpdates();
+      $this->assertFalse($needs_updates, 'After all updates ran, entity schema is up to date.');
+      if ($needs_updates) {
+        foreach (\Drupal::entityDefinitionUpdateManager()
+                   ->getChangeSummary() as $entity_type_id => $summary) {
+          foreach ($summary as $message) {
+            $this->fail($message);
+          }
         }
       }
     }

core/modules/system/tests/modules/entity_reference_test/config/install/views.view.test_entity_reference.yml

@@ -88,7 +88,7 @@ display:
           entity_field: title
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/taxonomy/config/optional/views.view.taxonomy_term.yml

@@ -182,7 +182,7 @@ display:
           group_type: group
           admin_label: ''
           operator: '='
-          value: true
+          value: '1'
           group: 1
           exposed: false
           expose:

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_argument_taxonomy_index_tid_depth.yml

@@ -130,7 +130,7 @@ display:
           field_api_classes: false
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           plugin_id: boolean

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_filter_taxonomy_index_tid.yml

@@ -116,7 +116,7 @@ display:
           entity_field: title
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_filter_taxonomy_index_tid__non_existing_dependency.yml

@@ -116,7 +116,7 @@ display:
           entity_field: title
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_filter_taxonomy_index_tid_depth.yml

@@ -116,7 +116,7 @@ display:
           entity_field: title
       filters:
         status:
-          value: true
+          value: '1'
           table: node_field_data
           field: status
           id: status

core/modules/user/config/optional/views.view.user_admin_people.yml

@@ -705,7 +705,7 @@ display:
           group_type: group
           admin_label: ''
           operator: '='
-          value: true
+          value: '1'
           group: 1
           exposed: true
           expose:
@@ -753,7 +753,7 @@ display:
           group_type: group
           admin_label: ''
           operator: '='
-          value: true
+          value: '1'
           group: 1
           exposed: false
           expose:

core/modules/user/config/optional/views.view.who_s_new.yml

@@ -89,7 +89,7 @@ display:
           entity_field: name
       filters:
         status:
-          value: true
+          value: '1'
           table: users_field_data
           field: status
           id: status

core/modules/user/config/optional/views.view.who_s_online.yml

@@ -96,7 +96,7 @@ display:
           entity_field: name
       filters:
         status:
-          value: true
+          value: '1'
           table: users_field_data
           field: status
           id: status

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_groupwise_user.yml

@@ -48,7 +48,7 @@ display:
           group: 1
           id: status
           table: users_field_data
-          value: true
+          value: '1'
           plugin_id: boolean
           entity_type: user
           entity_field: status

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_bulk_form.yml

@@ -52,7 +52,7 @@ display:
           table: users_field_data
           field: status
           operator: '='
-          value: true
+          value: '1'
           plugin_id: boolean
           entity_type: user
           entity_field: status

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_roles_rid.yml

@@ -126,7 +126,7 @@ display:
           field_api_classes: false
       filters:
         status:
-          value: true
+          value: '1'
           table: users_field_data
           field: status
           plugin_id: boolean

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_views_handler_field_role.yml

@@ -142,7 +142,7 @@ display:
           plugin_id: user_roles
       filters:
         status:
-          value: true
+          value: '1'
           table: users_field_data
           field: status
           id: status

core/modules/views/config/schema/views.filter.schema.yml

@@ -123,7 +123,7 @@ views.filter.group_item.numeric:
 # Schema for the views filter value.
 
 views.filter_value.boolean:
-  type: boolean
+  type: string
 
 views.filter_value.combine:
   type: string

core/modules/views/src/Tests/Update/BooleanFilterValuesUpdateTest.php

+<?php
+
+namespace Drupal\views\Tests\Update;
+
+use Drupal\system\Tests\Update\UpdatePathTestBase;
+use Drupal\views\Entity\View;
+
+/**
+ * Tests the upgrade path for boolean field values.
+ *
+ * @see views_post_update_boolean_filter_values()
+ *
+ * @group Update
+ */
+class BooleanFilterValuesUpdateTest extends UpdatePathTestBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setDatabaseDumpFiles() {
+    $this->databaseDumpFiles = [
+      __DIR__ . '/../../../../system/tests/fixtures/update/drupal-8.bare.standard.php.gz',
+      __DIR__ . '/../../../tests/fixtures/update/boolean-filter-values.php',
+    ];
+  }
+
+  /**
+   * Tests that boolean filter values are updated properly.
+   */
+  public function testViewsPostUpdateBooleanFilterValues() {
+    $this->runUpdates();
+
+    // Load and initialize our test view.
+    $view = View::load('test_boolean_filter_values');
+    $data = $view->toArray();
+    // Check that the field is using the expected string value.
+    $this->assertIdentical('1', $data['display']['default']['display_options']['filters']['status']['value']);
+  }
+
+}

core/modules/views/tests/fixtures/update/boolean-filter-values.php

+<?php
+
+/**
+ * @file
+ * Test fixture.
+ */
+
+use Drupal\Core\Database\Database;
+use Drupal\Core\Serialization\Yaml;
+
+$connection = Database::getConnection();
+
+$connection->insert('config')
+  ->fields(array(
+    'collection' => '',
+    'name' => 'views.view.test_boolean_filter_values',
+    'data' => serialize(Yaml::decode(file_get_contents('core/modules/views/tests/fixtures/update/views.view.test_boolean_filter_values.yml'))),
+  ))
+  ->execute();

core/modules/views/tests/fixtures/update/views.view.test_boolean_filter_values.yml

+langcode: en
+status: true
+dependencies:
+  module:
+    - node
+    - user
+id: test_boolean_filter_values
+label: Content
+module: node
+description: 'Find and manage content.'
+tag: default
+base_table: node_field_data
+base_field: nid
+core: 8.x
+display:
+  default:
+    display_options:
+      access:
+        type: perm
+        options:
+          perm: 'access content overview'
+      cache:
+        type: tag
+      query:
+        type: views_query
+      exposed_form:
+        type: basic
+        options:
+          submit_button: Filter
+          reset_button: true
+          reset_button_label: Reset
+          exposed_sorts_label: 'Sort by'
+          expose_sort_order: true
+          sort_asc_label: Asc
+          sort_desc_label: Desc
+      pager:
+        type: full
+        options:
+          items_per_page: 50
+          tags:
+            previous: '‹ Previous'
+            next: 'Next ›'
+            first: '« First'
+            last: 'Last »'
+      style:
+        type: table
+        options:
+          grouping: {  }
+          row_class: ''
+          default_row_class: true
+          override: true
+          sticky: true
+          caption: ''
+          summary: ''
+          description: ''
+          columns:
+            node_bulk_form: node_bulk_form
+            title: title
+            type: type
+            name: name
+            status: status
+            changed: changed
+            edit_node: edit_node
+            delete_node: delete_node
+            dropbutton: dropbutton
+            timestamp: title
+          info:
+            node_bulk_form:
+              align: ''
+              separator: ''
+              empty_column: false
+              responsive: ''
+            title:
+              sortable: true
+              default_sort_order: asc
+              align: ''
+              separator: ''
+              empty_column: false
+              responsive: ''
+            type:
+              sortable: true
+              default_sort_order: asc
+              align: ''
+              separator: ''
+              empty_column: false
+              responsive: ''
+            name:
+              sortable: false
+              default_sort_order: asc
+              align: ''
+              separator: ''
+              empty_column: false
+              responsive: priority-low
+            status:
+              sortable: true
+              default_sort_order: asc
+              align: ''
+              separator: ''
+              empty_column: false
+              responsive: ''
+            changed:
+              sortable: true
+              default_sort_order: desc
+              align: ''
+              separator: ''
+              empty_column: false
+              responsive: priority-low
+            edit_node:
+              sortable: false
+              default_sort_order: asc
+              align: ''
+              separator: ''
+              empty_column: false
+              responsive: ''
+            delete_node:
+              sortable: false
+              default_sort_order: asc
+              align: ''
+              separator: ''