Merge branch '3371963-update-nightwatch-to' into '11.x'

Issue #3371963: Update Nightwatch to 3.x

See merge request !4369

core/package.json

@@ -80,7 +80,7 @@
     "loadjs": "^4.3.0",
     "minimist": "^1.2.8",
     "mkdirp": "^3.0.1",
-    "nightwatch": "2.4.2",
+    "nightwatch": "^3.7.0",
     "normalize.css": "^8.0.1",
     "postcss": "^8.4.39",
     "postcss-header": "^3.0.3",

core/tests/Drupal/Nightwatch/Assertions/noDeprecationErrors.js

@@ -17,7 +17,11 @@ module.exports.assertion = function () {
   };
   this.command = (callback) =>
     // eslint-disable-next-line prefer-arrow-callback
-    this.api.execute(function () {
-      return window.sessionStorage.getItem('js_testing_log_test.warnings');
-    }, callback);
+    this.api.execute(
+      function () {
+        return window.sessionStorage.getItem('js_testing_log_test.warnings');
+      },
+      [],
+      callback,
+    );
 };

core/tests/Drupal/Nightwatch/Commands/drupalInstall.js

@@ -49,7 +49,6 @@ exports.command = function drupalInstall(
       // Colons need to be URL encoded to be valid.
       value: encodeURIComponent(installData.user_agent),
       path: url.pathname,
-      domain: url.host,
     });
   } catch (error) {
     this.assert.fail(error);