Issue #2475221 by alexpott: Remove some unused varaibles from views

core/modules/views/src/Plugin/views/area/Result.php

@@ -84,7 +84,6 @@ public function render($empty = FALSE) {
     // Calculate the page totals.
     $current_page = (int) $this->view->getCurrentPage() + 1;
     $per_page = (int) $this->view->getItemsPerPage();
-    $count = count($this->view->result);
     // @TODO: Maybe use a possible is views empty functionality.
     // Not every view has total_rows set, use view->result instead.
     $total = isset($this->view->total_rows) ? $this->view->total_rows : count($this->view->result);

core/modules/views/src/Plugin/views/field/Field.php

@@ -232,7 +232,6 @@ public function query($use_groupby = FALSE) {
       unset($fields[$entity_type_key]);
     }
 
-    $field_definition = $this->getFieldDefinition();
     if ($use_groupby) {
       // Add the fields that we're actually grouping on.
       $options = array();

core/modules/views/src/Plugin/views/join/JoinPluginBase.php

@@ -294,12 +294,6 @@ public function buildJoin($select_query, $table, $view_query) {
           // Convert a single-valued array of values to the single-value case,
           // and transform from IN() notation to = notation
           if (is_array($info['value']) && count($info['value']) == 1) {
-            if (empty($info['operator'])) {
-              $operator = '=';
-            }
-            else {
-              $operator = $info['operator'] == 'NOT IN' ? '!=' : '=';
-            }
             $info['value'] = array_shift($info['value']);
           }
 

core/modules/views/src/Tests/Handler/FieldWebTest.php

@@ -222,8 +222,6 @@ public function testAlterUrl() {
 
     // Some generic test code adapted from the UrlTest class, which tests
     // mostly the different options for the path.
-    global $base_url, $script_path;
-
     foreach (array(FALSE, TRUE) as $absolute) {
       $alter = &$id_field->options['alter'];
       $alter['path'] = 'node/123';

core/modules/views/views.theme.inc

@@ -1042,7 +1042,6 @@ function template_preprocess_views_mini_pager(&$variables) {
     $variables['items']['previous']['attributes'] = new Attribute();
   }
 
-  $li_next = array();
   if ($pager_page_array[$element] < ($pager_total[$element] - 1)) {
     $options = array(
       'query' => pager_query_add_page($parameters, $element, $pager_page_array[$element] + 1),