-
- Downloads
Fixed Image module tests. Added many critical todos:
- Config values are not casted to strings (despite promised). - Config keys are not casted to strings (although promised, too). - XML can be invalid and not parse-able for many reasons. - Config keys are not validated/sanitized. - config()->clear() should really be ->unset(). - Configuration must not be additionally cached by a module in any way (static cache / database cache). - Some modules invoke drupal_alter() on configuration (e.g., image styles). - Need a way to list config object names/suffixes _after_ a specified prefix. - Need a way to determine whether a config object exists. - Some modules might have a valid use-case for retrieving/listing config objects using a wildcard within the name (instead of only searching by prefix). - The key of a retrieved value is unknown; since you only get the value. Configuration values (or sub-values) may be passed forward to another function/callback, and thus, that function no longer knows about the key of the value. (unless the key is contained in the value, which is a very very wonky duplication) - Config keys must not contain periods (within a specific key).
parent
d74f856c
No related branches found
No related tags found
Showing
- core/includes/config.inc 6 additions, 2 deletionscore/includes/config.inc
- core/lib/Drupal/Core/Config/ConfigException.php 1 addition, 1 deletioncore/lib/Drupal/Core/Config/ConfigException.php
- core/lib/Drupal/Core/Config/DrupalConfig.php 10 additions, 0 deletionscore/lib/Drupal/Core/Config/DrupalConfig.php
- core/modules/image/image.install 0 additions, 81 deletionscore/modules/image/image.install
- core/modules/image/image.module 68 additions, 45 deletionscore/modules/image/image.module
- core/modules/image/image.test 1 addition, 1 deletioncore/modules/image/image.test
Loading
Please register or sign in to comment