Issue #2602662 by mikeryan, phenaproxima: Feed ID should be required base...

Issue #2602662 by mikeryan, phenaproxima: Feed ID should be required base field for aggregator items

core/modules/aggregator/aggregator.install

@@ -21,3 +21,19 @@ function aggregator_requirements($phase) {
   }
   return $requirements;
 }
+
+/**
+ * @addtogroup updates-8.0.0-rc
+ * @{
+ */
+
+/**
+ * The simple presence of this update function clears cached field definitions.
+ */
+function aggregator_update_8001() {
+  // Feed ID base field is now required.
+}
+
+/**
+ * @} End of "addtogroup updates-8.0.0-rc".
+ */

core/modules/aggregator/src/Entity/Item.php

@@ -60,6 +60,7 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
 
     $fields['fid'] = BaseFieldDefinition::create('entity_reference')
       ->setLabel(t('Source feed'))
+      ->setRequired(TRUE)
       ->setDescription(t('The aggregator feed entity associated with this item.'))
       ->setSetting('target_type', 'aggregator_feed')
       ->setDisplayOptions('view', array(

core/modules/aggregator/src/Tests/ItemWithoutFeedTest.php

+<?php
+
+/**
+ * @file
+ * Contains \Drupal\aggregator\Tests\ItemWithoutFeedTest.
+ */
+
+namespace Drupal\aggregator\Tests;
+
+use Drupal\aggregator\Entity\Item;
+use Drupal\KernelTests\KernelTestBase;
+
+/**
+ * Tests clean handling of an item with a missing feed ID.
+ *
+ * @group aggregator
+ */
+class ItemWithoutFeedTest extends KernelTestBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  public static $modules = ['aggregator', 'options'];
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp() {
+    parent::setUp();
+    $this->installEntitySchema('aggregator_feed');
+    $this->installEntitySchema('aggregator_item');
+  }
+
+  /**
+   * Tests attempting to create a feed item without a feed.
+   */
+  public function testEntityCreation() {
+    $entity = Item::create([
+      'title' => t('Llama 2'),
+      'path' => 'https://groups.drupal.org/',
+    ]);
+    $violations = $entity->validate();
+    $this->assertCount(1, $violations);
+  }
+
+}