Issue #3465836 by andypost: PHP 8.4 session.sid_length and...

Issue #3465836 by andypost: PHP 8.4 session.sid_length and session.sid_bits_per_character are deprecated

(cherry picked from commit 123216e5)

core/lib/Drupal/Core/Session/SessionConfiguration.php

@@ -58,6 +58,10 @@ public function getOptions(Request $request) {
     // Set the session cookie name.
     $options['name'] = $this->getName($request);
 
+    if (\PHP_VERSION_ID >= 80400) {
+      // See https://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sessionsid_bits_per_character
+      unset($options['sid_length'], $options['sid_bits_per_character']);
+    }
     return $options;
   }
 

core/tests/Drupal/Tests/Core/Session/SessionConfigurationTest.php

@@ -269,8 +269,14 @@ public static function providerTestEnforcedSessionName() {
   public function testConstructorDefaultSettings(array $options, int $expected_sid_length, int $expected_sid_bits_per_character, string $expected_name_suffix): void {
     $config = $this->createSessionConfiguration($options);
     $options = $config->getOptions(Request::createFromGlobals());
-    $this->assertSame($expected_sid_length, $options['sid_length']);
-    $this->assertSame($expected_sid_bits_per_character, $options['sid_bits_per_character']);
+    if (\PHP_VERSION_ID >= 80400) {
+      $this->assertArrayNotHasKey('sid_length', $options);
+      $this->assertArrayNotHasKey('sid_bits_per_character', $options);
+    }
+    else {
+      $this->assertSame($expected_sid_length, $options['sid_length']);
+      $this->assertSame($expected_sid_bits_per_character, $options['sid_bits_per_character']);
+    }
     $this->assertSame($expected_name_suffix, $options['name_suffix']);
   }