Revert "Issue #1923406 by stefan.r, yannickoo: Use ASCII character set on...

Revert "Issue #1923406 by stefan.r, yannickoo: Use ASCII character set on alphanumeric fields so we can index all 255 characters"

This reverts commit ac4e35ce.

core/config/schema/core.data_types.schema.yml

@@ -445,9 +445,6 @@ field.storage_settings.string:
     case_sensitive:
       type: boolean
       label: 'Case sensitive'
-    is_ascii:
-      type: boolean
-      label: 'Contains US ASCII characters only'
 
 field.field_settings.string:
   type: mapping

core/lib/Drupal/Core/Cache/DatabaseBackend.php

@@ -422,26 +422,22 @@ protected function catchException(\Exception $e, $table_name = NULL) {
   }
 
   /**
-   * Normalizes a cache ID in order to comply with database limitations.
+   * Ensures that cache IDs have a maximum length of 255 characters.
    *
    * @param string $cid
    *   The passed in cache ID.
    *
    * @return string
-   *   An ASCII-encoded cache ID that is at most 255 characters long.
+   *   A cache ID that is at most 255 characters long.
    */
   protected function normalizeCid($cid) {
-    // Nothing to do if the ID is a US ASCII string of 255 characters or less.
-    $cid_is_ascii = mb_check_encoding($cid, 'ASCII');
-    if (strlen($cid) <= 255 && $cid_is_ascii) {
+    // Nothing to do if the ID length is 255 characters or less.
+    if (strlen($cid) <= 255) {
       return $cid;
     }
     // Return a string that uses as much as possible of the original cache ID
     // with the hash appended.
     $hash = Crypt::hashBase64($cid);
-    if (!$cid_is_ascii) {
-      return $hash;
-    }
     return substr($cid, 0, 255 - strlen($hash)) . $hash;
   }
 
@@ -454,7 +450,7 @@ public function schemaDefinition() {
       'fields' => array(
         'cid' => array(
           'description' => 'Primary Key: Unique cache ID.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 255,
           'not null' => TRUE,
           'default' => '',
@@ -495,7 +491,7 @@ public function schemaDefinition() {
         ),
         'checksum' => array(
           'description' => 'The tag invalidation checksum when this entry was saved.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 255,
           'not null' => TRUE,
         ),

core/lib/Drupal/Core/Cache/DatabaseCacheTagsChecksum.php

@@ -175,7 +175,7 @@ public function schemaDefinition() {
       'fields' => array(
         'tag' => array(
           'description' => 'Namespace-prefixed tag string.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 255,
           'not null' => TRUE,
           'default' => '',

core/lib/Drupal/Core/Config/DatabaseStorage.php

@@ -192,14 +192,14 @@ protected static function schemaDefinition() {
       'fields' => array(
         'collection' => array(
           'description' => 'Primary Key: Config object collection.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 255,
           'not null' => TRUE,
           'default' => '',
         ),
         'name' => array(
           'description' => 'Primary Key: Config object name.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 255,
           'not null' => TRUE,
           'default' => '',

core/lib/Drupal/Core/Database/Driver/mysql/Schema.php

@@ -144,10 +144,6 @@ protected function createFieldSql($name, $spec) {
       if (!empty($spec['binary'])) {
         $sql .= ' BINARY';
       }
-      // Note we check for the "type" key here. "mysql_type" is VARCHAR:
-      if (isset($spec['type']) && $spec['type'] == 'varchar_ascii') {
-        $sql .= ' CHARACTER SET ascii COLLATE ascii_general_ci';
-      }
     }
     elseif (isset($spec['precision']) && isset($spec['scale'])) {
       $sql .= '(' . $spec['precision'] . ', ' . $spec['scale'] . ')';
@@ -222,8 +218,6 @@ public function getFieldTypeMap() {
     // database types back into schema types.
     // $map does not use drupal_static as its value never changes.
     static $map = array(
-      'varchar_ascii:normal' => 'VARCHAR',
-
       'varchar:normal'  => 'VARCHAR',
       'char:normal'     => 'CHAR',
 

core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php

@@ -363,8 +363,6 @@ function getFieldTypeMap() {
     // database types back into schema types.
     // $map does not use drupal_static as its value never changes.
     static $map = array(
-      'varchar_ascii:normal' => 'varchar',
-
       'varchar:normal' => 'varchar',
       'char:normal' => 'character',
 

core/lib/Drupal/Core/Database/Driver/sqlite/Schema.php

@@ -212,8 +212,6 @@ public function getFieldTypeMap() {
     // database types back into schema types.
     // $map does not use drupal_static as its value never changes.
     static $map = array(
-      'varchar_ascii:normal' => 'VARCHAR',
-
       'varchar:normal'  => 'VARCHAR',
       'char:normal'     => 'CHAR',
 

core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php

@@ -1568,7 +1568,7 @@ protected function getDedicatedTableSchema(FieldStorageDefinitionInterface $stor
     }
     else {
       $id_schema = array(
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'length' => 128,
         'not null' => TRUE,
         'description' => 'The entity id this data is attached to',
@@ -1601,7 +1601,7 @@ protected function getDedicatedTableSchema(FieldStorageDefinitionInterface $stor
       'description' => $description_current,
       'fields' => array(
         'bundle' => array(
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 128,
           'not null' => TRUE,
           'default' => '',
@@ -1617,7 +1617,7 @@ protected function getDedicatedTableSchema(FieldStorageDefinitionInterface $stor
         'entity_id' => $id_schema,
         'revision_id' => $revision_id_schema,
         'langcode' => array(
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 32,
           'not null' => TRUE,
           'default' => '',

core/lib/Drupal/Core/Field/Plugin/Field/FieldType/EntityReferenceItem.php

@@ -133,7 +133,7 @@ public static function schema(FieldStorageDefinitionInterface $field_definition)
       $columns = array(
         'target_id' => array(
           'description' => 'The ID of the target entity.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           // If the target entities act as bundles for another entity type,
           // their IDs should not exceed the maximum length for bundles.
           'length' => $target_type_info->getBundleOf() ? EntityTypeInterface::BUNDLE_MAX_LENGTH : 255,

core/lib/Drupal/Core/Field/Plugin/Field/FieldType/LanguageItem.php

@@ -44,7 +44,6 @@ class LanguageItem extends FieldItemBase {
   public static function propertyDefinitions(FieldStorageDefinitionInterface $field_definition) {
     $properties['value'] = DataDefinition::create('string')
       ->setLabel(t('Language code'))
-      ->setSetting('is_ascii', TRUE)
       ->setRequired(TRUE);
 
     $properties['language'] = DataReferenceDefinition::create('language')
@@ -76,7 +75,6 @@ public static function schema(FieldStorageDefinitionInterface $field_definition)
         'value' => array(
           'type' => 'varchar',
           'length' => 12,
-          'is_ascii' => TRUE,
         ),
       ),
     );

core/lib/Drupal/Core/Field/Plugin/Field/FieldType/StringItem.php

@@ -32,7 +32,6 @@ class StringItem extends StringItemBase {
   public static function defaultStorageSettings() {
     return array(
       'max_length' => 255,
-      'is_ascii' => FALSE,
     ) + parent::defaultStorageSettings();
   }
 
@@ -43,7 +42,7 @@ public static function schema(FieldStorageDefinitionInterface $field_definition)
     return array(
       'columns' => array(
         'value' => array(
-          'type' => $field_definition->getSetting('is_ascii') === TRUE ? 'varchar_ascii' : 'varchar',
+          'type' => 'varchar',
           'length' => (int) $field_definition->getSetting('max_length'),
           'binary' => $field_definition->getSetting('case_sensitive'),
         ),

core/lib/Drupal/Core/Field/Plugin/Field/FieldType/UuidItem.php

@@ -30,7 +30,6 @@ class UuidItem extends StringItem {
   public static function defaultStorageSettings() {
     return array(
       'max_length' => 128,
-      'is_ascii' => TRUE,
     ) + parent::defaultStorageSettings();
   }
 

core/lib/Drupal/Core/Menu/MenuTreeStorage.php

@@ -1193,7 +1193,7 @@ protected static function schemaDefinition() {
       'fields' => array(
         'menu_name' => array(
           'description' => "The menu name. All links with the same menu name (such as 'tools') are part of the same menu.",
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 32,
           'not null' => TRUE,
           'default' => '',
@@ -1206,20 +1206,20 @@ protected static function schemaDefinition() {
         ),
         'id' => array(
           'description' => 'Unique machine name: the plugin ID.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 255,
           'not null' => TRUE,
         ),
         'parent' => array(
           'description' => 'The plugin ID for the parent of this link.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 255,
           'not null' => TRUE,
           'default' => '',
         ),
         'route_name' => array(
           'description' => 'The machine name of a defined Symfony Route this menu item represents.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => 255,
         ),
         'route_param_key' => array(
@@ -1281,7 +1281,7 @@ protected static function schemaDefinition() {
         ),
         'provider' => array(
           'description' => 'The name of the module that generated this link.',
-          'type' => 'varchar_ascii',
+          'type' => 'varchar',
           'length' => DRUPAL_EXTENSION_NAME_MAX_LENGTH,
           'not null' => TRUE,
           'default' => 'system',

core/modules/aggregator/src/Entity/Feed.php

@@ -226,7 +226,6 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
 
     $fields['hash'] = BaseFieldDefinition::create('string')
       ->setLabel(t('Hash'))
-      ->setSetting('is_ascii', TRUE)
       ->setDescription(t('Calculated hash of the feed data, used for validating cache.'));
 
     $fields['etag'] = BaseFieldDefinition::create('string')

core/modules/aggregator/src/FeedInterface.php

@@ -170,8 +170,7 @@ public function getHash();
    * Sets the calculated hash of the feed data, used for validating cache.
    *
    * @param string $hash
-   *   A string containing the calculated hash of the feed. Must contain
-   *   US ASCII characters only.
+   *   A string containing the calculated hash of the feed.
    *
    * @return \Drupal\aggregator\FeedInterface
    *   The class instance that this method is called on.

core/modules/ban/ban.install

@@ -20,7 +20,7 @@ function ban_schema() {
       ),
       'ip' => array(
         'description' => 'IP address',
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'length' => 40,
         'not null' => TRUE,
         'default' => '',

core/modules/comment/comment.install

@@ -46,14 +46,14 @@ function comment_schema() {
         'description' => 'The entity_id of the entity for which the statistics are compiled.',
       ),
       'entity_type' => array(
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'not null' => TRUE,
         'default' => 'node',
         'length' => EntityTypeInterface::ID_MAX_LENGTH,
         'description' => 'The entity_type of the entity to which this comment is a reply.',
       ),
       'field_name' => array(
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'not null' => TRUE,
         'default' => '',
         'length' => FieldStorageConfig::NAME_MAX_LENGTH,

core/modules/comment/src/Entity/Comment.php

@@ -303,7 +303,6 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
     $fields['entity_type'] = BaseFieldDefinition::create('string')
       ->setLabel(t('Entity type'))
       ->setDescription(t('The entity type to which this comment is attached.'))
-      ->setSetting('is_ascii', TRUE)
       ->setSetting('max_length', EntityTypeInterface::ID_MAX_LENGTH);
 
     $fields['comment_type'] = BaseFieldDefinition::create('entity_reference')
@@ -314,7 +313,6 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
     $fields['field_name'] = BaseFieldDefinition::create('string')
       ->setLabel(t('Comment field name'))
       ->setDescription(t('The field name through which this comment was added.'))
-      ->setSetting('is_ascii', TRUE)
       ->setSetting('max_length', FieldStorageConfig::NAME_MAX_LENGTH);
 
     return $fields;

core/modules/dblog/dblog.install

@@ -25,7 +25,7 @@ function dblog_schema() {
         'description' => 'The {users}.uid of the user who triggered the event.',
       ),
       'type' => array(
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'length' => 64,
         'not null' => TRUE,
         'default' => '',
@@ -69,7 +69,7 @@ function dblog_schema() {
         'description' => 'URL of referring page.',
       ),
       'hostname' => array(
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'length' => 128,
         'not null' => TRUE,
         'default' => '',

core/modules/file/file.install

@@ -20,21 +20,21 @@ function file_schema() {
       ),
       'module' => array(
         'description' => 'The name of the module that is using the file.',
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'length' => DRUPAL_EXTENSION_NAME_MAX_LENGTH,
         'not null' => TRUE,
         'default' => '',
       ),
       'type' => array(
         'description' => 'The name of the object type in which the file is used.',
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'length' => 64,
         'not null' => TRUE,
         'default' => '',
       ),
       'id' => array(
         'description' => 'The primary key of the object using the file.',
-        'type' => 'varchar_ascii',
+        'type' => 'varchar',
         'length' => 64,
         'not null' => TRUE,
         'default' => 0,