Skip to content
Snippets Groups Projects
Verified Commit 1b80269c authored by Dave Long's avatar Dave Long
Browse files

Issue #3377000 by Spokje, longwave, xjm: Remove phpstan ignore for "#^Missing... 

Issue #3377000 by Spokje, longwave, xjm: Remove phpstan ignore for "#^Missing cache backend declaration for performance.#"

(cherry picked from commit 6514a929)
parent d7088b45
No related branches found
No related tags found
20 merge requests!8376Drupal views: adding more granularity to the ‘use ajax’ functionality,!8300Issue #3443586 View area displays even when parent view has no results.,!7567Issue #3153723 by quietone, Hardik_Patel_12: Change the scaffolding...,!7565Issue #3153723 by quietone, Hardik_Patel_12: Change the scaffolding...,!7509Change label "Block description" to "Block type",!7344Issue #3292350 by O'Briat, KlemenDEV, hswong3i, smustgrave, quietone: Update...,!6922Issue #3412959 by quietone, smustgrave, longwave: Fix 12 'un' words,!6848Issue #3417553 by longwave: Remove withConsecutive() in CacheCollectorTest,!6720Revert "Issue #3358581 by pfrenssen, _tarik_, a.dmitriiev, smustgrave:...,!6560Update ClaroPreRender.php, confirming classes provided are in array format,!6528Issue #3414261 by catch: Add authenticated user umami performance tests,!6501Issue #3263668 by omkar-pd, Wim Leers, hooroomoo: Re-enable inline form errors...,!6354Draft: Issue #3380392 by phma: Updating language weight from the overview reverts label if translated,!6324Issue #3416723 by Ludo.R: Provide a "node type" views default argument,!6119Issue #3405704 by Spokje, longwave: symfony/psr-http-message-bridge major version bump,!5950Issue #3403653 by alexpott, longwave: Incorporate improvements to how contrib runs PHPStan to core,!5858Issue #3401971 by fjgarlin: Test-only job shouldn't require constant rebases...,!5716Draft: Issue #3401102 by Spokje, longwave, smustgrave: Nightwatch artifacts on GitLab not retained,!5674Transaction autocommit during shutdown relies on unreliable object destruction order,!5644Issue #3395563 by nireneko, marvil07, lauriii, borisson_, smustgrave, Wim...
Pipeline #48602 failed
Stage: 🏗️ Build
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#48607

    Pipeline: drupal

    #48606

      Pipeline: drupal

      #48605

        +1
        Hide whitespace changes
        Inline Side-by-side
        core/phpstan-baseline.neon
        + 75
        − 0
        View file @ 1b80269c
        ...@@ -901,6 +901,11 @@ parameters: ...@@ -901,6 +901,11 @@ parameters:
        count: 1 count: 1
        path: lib/Drupal/Core/Menu/MenuLinkManager.php path: lib/Drupal/Core/Menu/MenuLinkManager.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: lib/Drupal/Core/Menu/MenuLinkManager.php
        - -
        message: """ message: """
        #^Fetching deprecated class constant RETURN_INSERT_ID of class Drupal\\\\Core\\\\Database\\\\Database\\: #^Fetching deprecated class constant RETURN_INSERT_ID of class Drupal\\\\Core\\\\Database\\\\Database\\:
        ...@@ -915,6 +920,11 @@ parameters: ...@@ -915,6 +920,11 @@ parameters:
        count: 1 count: 1
        path: lib/Drupal/Core/Menu/MenuTreeStorage.php path: lib/Drupal/Core/Menu/MenuTreeStorage.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: lib/Drupal/Core/Plugin/DefaultPluginManager.php
        - -
        message: "#^Constructor of class Drupal\\\\Core\\\\Queue\\\\Memory has an unused parameter \\$name\\.$#" message: "#^Constructor of class Drupal\\\\Core\\\\Queue\\\\Memory has an unused parameter \\$name\\.$#"
        count: 1 count: 1
        ...@@ -1830,6 +1840,16 @@ parameters: ...@@ -1830,6 +1840,16 @@ parameters:
        count: 1 count: 1
        path: modules/migrate/src/Plugin/Discovery/AnnotatedClassDiscoveryAutomatedProviders.php path: modules/migrate/src/Plugin/Discovery/AnnotatedClassDiscoveryAutomatedProviders.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/migrate/src/Plugin/MigrateDestinationPluginManager.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/migrate/src/Plugin/MigrateSourcePluginManager.php
        - -
        message: "#^Constructor of class Drupal\\\\migrate\\\\Plugin\\\\MigrationPluginManager has an unused parameter \\$language_manager\\.$#" message: "#^Constructor of class Drupal\\\\migrate\\\\Plugin\\\\MigrationPluginManager has an unused parameter \\$language_manager\\.$#"
        count: 1 count: 1
        ...@@ -1875,6 +1895,11 @@ parameters: ...@@ -1875,6 +1895,11 @@ parameters:
        count: 2 count: 2
        path: modules/migrate/tests/src/Unit/process/SubProcessTest.php path: modules/migrate/tests/src/Unit/process/SubProcessTest.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/migrate_drupal/src/MigrationPluginManager.php
        - -
        message: "#^Variable \\$patterns might not be defined\\.$#" message: "#^Variable \\$patterns might not be defined\\.$#"
        count: 1 count: 1
        ...@@ -1905,6 +1930,11 @@ parameters: ...@@ -1905,6 +1930,11 @@ parameters:
        count: 1 count: 1
        path: modules/migrate_drupal/tests/src/Kernel/d7/ValidateMigrationStateTest.php path: modules/migrate_drupal/tests/src/Kernel/d7/ValidateMigrationStateTest.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/migrate_drupal/tests/src/Unit/MigrateFieldPluginManagerTest.php
        - -
        message: "#^Variable \\$patterns might not be defined\\.$#" message: "#^Variable \\$patterns might not be defined\\.$#"
        count: 1 count: 1
        ...@@ -2349,6 +2379,31 @@ parameters: ...@@ -2349,6 +2379,31 @@ parameters:
        count: 1 count: 1
        path: modules/system/tests/modules/service_provider_test/src/TestClass.php path: modules/system/tests/modules/service_provider_test/src/TestClass.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/system/tests/modules/lazy_route_provider_install_test/src/PluginManager.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/system/tests/modules/module_test/src/PluginManagerCacheClearer.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/system/tests/modules/plugin_test/src/Plugin/DefaultsTestPluginManager.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/system/tests/modules/plugin_test/src/Plugin/MockBlockManager.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: modules/system/tests/modules/plugin_test/src/Plugin/TestPluginManager.php
        - -
        message: """ message: """
        #^Usage of deprecated trait Symfony\\\\Component\\\\DependencyInjection\\\\ContainerAwareTrait in class Drupal\\\\service_provider_test\\\\TestClass\\: #^Usage of deprecated trait Symfony\\\\Component\\\\DependencyInjection\\\\ContainerAwareTrait in class Drupal\\\\service_provider_test\\\\TestClass\\:
        ...@@ -3330,6 +3385,11 @@ parameters: ...@@ -3330,6 +3385,11 @@ parameters:
        count: 1 count: 1
        path: tests/Drupal/Tests/Component/Plugin/Factory/ReflectionFactoryTest.php path: tests/Drupal/Tests/Component/Plugin/Factory/ReflectionFactoryTest.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: tests/Drupal/Tests/Component/Plugin/StubPluginManagerBaseWithMapper.php
        - -
        message: "#^Result of static method Drupal\\\\Composer\\\\Composer\\:\\:ensureComposerVersion\\(\\) \\(void\\) is used\\.$#" message: "#^Result of static method Drupal\\\\Composer\\\\Composer\\:\\:ensureComposerVersion\\(\\) \\(void\\) is used\\.$#"
        count: 1 count: 1
        ...@@ -3505,6 +3565,11 @@ parameters: ...@@ -3505,6 +3565,11 @@ parameters:
        count: 1 count: 1
        path: tests/Drupal/Tests/Core/Plugin/CategorizingPluginManagerTraitTest.php path: tests/Drupal/Tests/Core/Plugin/CategorizingPluginManagerTraitTest.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: tests/Drupal/Tests/Core/Plugin/CategorizingPluginManagerTraitTest.php
        - -
        message: "#^Call to deprecated method withConsecutive\\(\\) of class PHPUnit\\\\Framework\\\\MockObject\\\\Builder\\\\InvocationMocker\\.$#" message: "#^Call to deprecated method withConsecutive\\(\\) of class PHPUnit\\\\Framework\\\\MockObject\\\\Builder\\\\InvocationMocker\\.$#"
        count: 1 count: 1
        ...@@ -3515,11 +3580,21 @@ parameters: ...@@ -3515,11 +3580,21 @@ parameters:
        count: 1 count: 1
        path: tests/Drupal/Tests/Core/Plugin/Discovery/TestContainerDerivativeDiscovery.php path: tests/Drupal/Tests/Core/Plugin/Discovery/TestContainerDerivativeDiscovery.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: tests/Drupal/Tests/Core/Plugin/FilteredPluginManagerTraitTest.php
        - -
        message: "#^Constructor of class Drupal\\\\Tests\\\\Core\\\\Plugin\\\\TestPluginManager has an unused parameter \\$namespaces\\.$#" message: "#^Constructor of class Drupal\\\\Tests\\\\Core\\\\Plugin\\\\TestPluginManager has an unused parameter \\$namespaces\\.$#"
        count: 1 count: 1
        path: tests/Drupal/Tests/Core/Plugin/TestPluginManager.php path: tests/Drupal/Tests/Core/Plugin/TestPluginManager.php
        -
        message: "#^Missing cache backend declaration for performance\\.$#"
        count: 1
        path: tests/Drupal/Tests/Core/Plugin/TestPluginManager.php
        - -
        message: """ message: """
        #^Call to deprecated method expectError\\(\\) of class PHPUnit\\\\Framework\\\\TestCase\\: #^Call to deprecated method expectError\\(\\) of class PHPUnit\\\\Framework\\\\TestCase\\:
        ......
        core/phpstan.neon.dist
        + 0
        − 1
        View file @ 1b80269c
        ...@@ -37,5 +37,4 @@ parameters: ...@@ -37,5 +37,4 @@ parameters:
        # Ignore common errors for now. # Ignore common errors for now.
        - "#Drupal calls should be avoided in classes, use dependency injection instead#" - "#Drupal calls should be avoided in classes, use dependency injection instead#"
        - "#^Plugin definitions cannot be altered.#" - "#^Plugin definitions cannot be altered.#"
        - "#^Missing cache backend declaration for performance.#"
        - "#^Class .* extends @internal class#" - "#^Class .* extends @internal class#"
        0% or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment