Issue #3486526 by theodorejb, andypost, nicxvan: Inconsistent switch case syntax

core/modules/field/src/FieldConfigStorage.php

@@ -150,11 +150,11 @@ public function loadByProperties(array $conditions = []) {
             $checked_value = $field_storage->uuid();
             break;
 
-          case 'uuid';
+          case 'uuid':
             $checked_value = $field->uuid();
             break;
 
-          case 'deleted';
+          case 'deleted':
             $checked_value = $field->isDeleted();
             break;
 

core/modules/field/src/Plugin/migrate/process/d6/FieldInstanceOptionTranslation.php

@@ -30,7 +30,7 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
       $list = array_map('trim', $list);
       $list = FilterArray::removeEmptyStrings($list);
       switch ($field_type) {
-        case 'boolean';
+        case 'boolean':
           $option = preg_replace('/^option_/', '', $row->getSourceProperty('property'));
           for ($i = 0; $i < 2; $i++) {
             $value = $list[$i];

core/modules/field/src/Plugin/migrate/process/d7/FieldInstanceOptionTranslation.php

@@ -29,7 +29,7 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
     if (isset($data['settings']['allowed_values'])) {
       $allowed_values = $data['settings']['allowed_values'];
       switch ($type) {
-        case 'boolean';
+        case 'boolean':
           if (isset($allowed_values[$property])) {
             $translation = $row->getSourceProperty('translation');
             break;

core/modules/jsonapi/tests/src/Functional/CommentTest.php

@@ -293,10 +293,10 @@ protected function getExpectedCacheContexts(?array $sparse_fieldset = NULL) {
    */
   protected function getExpectedUnauthorizedAccessMessage($method) {
     switch ($method) {
-      case 'GET';
+      case 'GET':
         return "The 'access comments' permission is required and the comment must be published.";
 
-      case 'POST';
+      case 'POST':
         return "The 'post comments' permission is required.";
 
       case 'PATCH':

core/modules/jsonapi/tests/src/Functional/MediaTest.php

@@ -323,7 +323,7 @@ protected function getPostDocument(): array {
    */
   protected function getExpectedUnauthorizedAccessMessage($method) {
     switch ($method) {
-      case 'GET';
+      case 'GET':
         return "The 'view media' permission is required when the media item is published.";
 
       case 'POST':

core/modules/language/src/Plugin/migrate/process/ContentTranslationEnabledSetting.php

@@ -32,7 +32,7 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
     switch ($language_content_type) {
       // In the case of being 0, it will be skipped. We are not actually setting
       // a null value.
-      case 0;
+      case 0:
         $setting = NULL;
         break;
 

core/modules/media/tests/src/Functional/Rest/MediaResourceTestBase.php

@@ -292,7 +292,7 @@ protected function getNormalizedPatchEntity() {
    */
   protected function getExpectedUnauthorizedAccessMessage($method) {
     switch ($method) {
-      case 'GET';
+      case 'GET':
         return "The 'view media' permission is required when the media item is published.";
 
       case 'POST':

core/modules/user/src/EventSubscriber/AccessDeniedSubscriber.php

@@ -64,12 +64,12 @@ public function on403(ExceptionEvent $event): void {
     $redirect_url = NULL;
     if ($this->account->isAuthenticated()) {
       switch ($route_name) {
-        case 'user.login';
+        case 'user.login':
           // Redirect an authenticated user to the profile page.
           $redirect_url = Url::fromRoute('entity.user.canonical', ['user' => $this->account->id()], ['absolute' => TRUE]);
           break;
 
-        case 'user.register';
+        case 'user.register':
           // Redirect an authenticated user to the profile form.
           $redirect_url = Url::fromRoute('entity.user.edit_form', ['user' => $this->account->id()], ['absolute' => TRUE]);
           break;

core/modules/views/src/Plugin/views/sort/SortPluginBase.php

@@ -68,8 +68,8 @@ public function adminSummary() {
       default:
         return $this->t('asc');
 
-      case 'DESC';
-      case 'desc';
+      case 'DESC':
+      case 'desc':
         return $this->t('desc');
     }
   }

core/tests/Drupal/KernelTests/Config/DefaultConfigTest.php

@@ -86,7 +86,7 @@ protected function assertExtensionConfig(string $name, string $type): void {
         $file_name = DRUPAL_ROOT . '/core/modules/system/tests/modules/' . $name . '/' . $name . '.info.yml';
         break;
 
-      default;
+      default:
         $file_name = DRUPAL_ROOT . '/core/' . $type . 's/' . $name . '/' . $name . '.info.yml';
     }