Issue #3477668 by quietone, lavanyatalwar, daffie: Fix...

Issue #3477668 by quietone, lavanyatalwar, daffie: Fix Drupal.Commenting.VariableComment.Missing in non-tests

core/lib/Drupal/Component/Utility/Timer.php

@@ -9,6 +9,11 @@
  */
 class Timer {
 
+  /**
+   * An associative array of timers.
+   *
+   * @var array
+   */
   protected static $timers = [];
 
   /**

core/lib/Drupal/Core/Datetime/DateFormatter.php

@@ -53,6 +53,11 @@ class DateFormatter implements DateFormatterInterface {
    */
   protected $requestStack;
 
+  /**
+   * The available date formats.
+   *
+   * @var array
+   */
   protected $dateFormats = [];
 
   /**

core/lib/Drupal/Core/Entity/Plugin/Validation/Constraint/EntityChangedConstraint.php

@@ -16,6 +16,9 @@
 )]
 class EntityChangedConstraint extends SymfonyConstraint {
 
+  /**
+   * The default violation message.
+   */
   public $message = 'The content has either been modified by another user, or you have already submitted modifications. As a result, your changes cannot be saved.';
 
 }

core/lib/Drupal/Core/Entity/Plugin/Validation/Constraint/EntityUntranslatableFieldsConstraint.php

@@ -16,7 +16,14 @@
 )]
 class EntityUntranslatableFieldsConstraint extends SymfonyConstraint {
 
+  /**
+   * The message when updating a field but not the current revision.
+   */
   public $defaultRevisionMessage = 'Non-translatable fields can only be changed when updating the current revision.';
+
+  /**
+   * The message when updating a field but not the original language.
+   */
   public $defaultTranslationMessage = 'Non-translatable fields can only be changed when updating the original language.';
 
 }

core/lib/Drupal/Core/Recipe/ConfigConfigurator.php

@@ -14,8 +14,14 @@
  */
 final class ConfigConfigurator {
 
+  /**
+   * The configuration directory for the recipe.
+   */
   public readonly ?string $recipeConfigDirectory;
 
+  /**
+   * Indicates how the shipped and active config are compared.
+   */
   private readonly bool|array $strict;
 
   /**

core/lib/Drupal/Core/Recipe/RecipeInputFormTrait.php

@@ -64,7 +64,7 @@ protected function buildRecipeInputForm(Recipe $recipe): array {
        *
        * @var array
        */
-      // phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable
+      // phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable, Drupal.Commenting.VariableComment.Missing
       public array $form = [];
 
       /**

core/lib/Drupal/Core/Validation/Plugin/Validation/Constraint/PrimitiveTypeConstraint.php

@@ -15,6 +15,9 @@
 )]
 class PrimitiveTypeConstraint extends SymfonyConstraint {
 
+  /**
+   * The default violation message.
+   */
   public $message = 'This value should be of the correct primitive type.';
 
 }

core/lib/Drupal/Core/Validation/Plugin/Validation/Constraint/UniqueFieldConstraint.php

@@ -15,6 +15,9 @@
 )]
 class UniqueFieldConstraint extends SymfonyConstraint {
 
+  /**
+   * The default violation message.
+   */
   public $message = 'A @entity_type with @field_name %value already exists.';
 
   /**

core/modules/content_moderation/src/Plugin/Validation/Constraint/ModerationStateConstraint.php

@@ -15,8 +15,19 @@
 )]
 class ModerationStateConstraint extends SymfonyConstraint {
 
+  /**
+   * The default violation message.
+   */
   public $message = 'Invalid state transition from %from to %to';
+
+  /**
+   * The violation message when there is an invalid stated.
+   */
   public $invalidStateMessage = 'State %state does not exist on %workflow workflow';
+
+  /**
+   * The violation message when there is an invalid transition.
+   */
   public $invalidTransitionAccess = 'You do not have access to transition from %original_state to %new_state';
 
 }

core/modules/file/src/Plugin/Validation/Constraint/FileUriUnique.php

@@ -16,6 +16,11 @@
 )]
 class FileUriUnique extends UniqueFieldConstraint {
 
+  /**
+   * The error message.
+   *
+   * @var string
+   */
   public $message = 'The file %value already exists. Enter a unique file URI.';
 
   /**

core/modules/link/src/Plugin/Validation/Constraint/LinkAccessConstraint.php

@@ -15,6 +15,11 @@
 )]
 class LinkAccessConstraint extends SymfonyConstraint {
 
+  /**
+   * The error message.
+   *
+   * @var string
+   */
   public $message = "The path '@uri' is inaccessible.";
 
 }

core/modules/link/src/Plugin/Validation/Constraint/LinkExternalProtocolsConstraint.php

@@ -15,6 +15,11 @@
 )]
 class LinkExternalProtocolsConstraint extends SymfonyConstraint {
 
+  /**
+   * The error message.
+   *
+   * @var string
+   */
   public $message = "The path '@uri' is invalid.";
 
 }

core/modules/link/src/Plugin/Validation/Constraint/LinkNotExistingInternalConstraint.php

@@ -15,6 +15,11 @@
 )]
 class LinkNotExistingInternalConstraint extends SymfonyConstraint {
 
+  /**
+   * The error message.
+   *
+   * @var string
+   */
   public $message = "The path '@uri' is invalid.";
 
 }

core/modules/link/src/Plugin/Validation/Constraint/LinkTypeConstraint.php

@@ -15,6 +15,11 @@
 )]
 class LinkTypeConstraint extends SymfonyConstraint {
 
+  /**
+   * The error message.
+   *
+   * @var string
+   */
   public $message = "The path '@uri' is invalid.";
 
 }

core/modules/menu_ui/src/Plugin/Validation/Constraint/MenuSettingsConstraint.php

@@ -15,9 +15,24 @@
 )]
 class MenuSettingsConstraint extends SymfonyConstraint {
 
+  /**
+   * The default violation message.
+   */
   public $message = 'You can only change the menu settings for the <em>published</em> version of this content.';
+
+  /**
+   * The violation message when the weight cannot be changed.
+   */
   public $messageWeight = 'You can only change the menu link weight for the <em>published</em> version of this content.';
+
+  /**
+   * The violation message when changing the parent for a unpublished content.
+   */
   public $messageParent = 'You can only change the parent menu link for the <em>published</em> version of this content.';
+
+  /**
+   * The violation message when removing a menu link for unpublished content.
+   */
   public $messageRemove = 'You can only remove the menu link in the <em>published</em> version of this content.';
 
 }

core/modules/path/src/Plugin/Validation/Constraint/PathAliasConstraint.php

@@ -15,6 +15,9 @@
 )]
 class PathAliasConstraint extends SymfonyConstraint {
 
+  /**
+   * The default violation message.
+   */
   public $message = 'You can only change the URL alias for the <em>published</em> version of this content.';
 
 }

core/modules/user/src/Plugin/Validation/Constraint/UserMailUnique.php

@@ -15,6 +15,9 @@
 )]
 class UserMailUnique extends UniqueFieldConstraint {
 
+  /**
+   * The default violation message.
+   */
   public $message = 'The email address %value is already taken.';
 
 }

core/modules/user/src/Plugin/Validation/Constraint/UserNameConstraint.php

@@ -15,11 +15,34 @@
 )]
 class UserNameConstraint extends SymfonyConstraint {
 
+  /**
+   * The violation message when there is no username.
+   */
   public $emptyMessage = 'You must enter a username.';
+
+  /**
+   * The violation message when the username begins with whitespace.
+   */
   public $spaceBeginMessage = 'The username cannot begin with a space.';
+
+  /**
+   * The violation message when the username ends with whitespace.
+   */
   public $spaceEndMessage = 'The username cannot end with a space.';
+
+  /**
+   * The violation message when the username has consecutive whitespace.
+   */
   public $multipleSpacesMessage = 'The username cannot contain multiple spaces in a row.';
+
+  /**
+   * The violation message when the username uses an invalid character.
+   */
   public $illegalMessage = 'The username contains an illegal character.';
+
+  /**
+   * The violation message when the username length exceeds the maximum allowed.
+   */
   public $tooLongMessage = 'The username %name is too long: it must be %max characters or less.';
 
 }

core/modules/user/src/Plugin/Validation/Constraint/UserNameUnique.php

@@ -15,6 +15,9 @@
 )]
 class UserNameUnique extends UniqueFieldConstraint {
 
+  /**
+   * The default violation message.
+   */
   public $message = 'The username %value is already taken.';
 
 }

core/modules/user/src/Plugin/views/filter/Name.php

@@ -16,6 +16,9 @@
 #[ViewsFilter("user_name")]
 class Name extends InOperator {
 
+  /**
+   * This filter is always considered multiple-valued.
+   */
   protected $alwaysMultiple = TRUE;
 
   /**