Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
drupal
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
drupal
Commits
187a3c54
Commit
187a3c54
authored
8 years ago
by
catch
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#2689655
by cafuego: D8 Comment date views arguments uses incorrect database column
parent
f9595403
No related branches found
Branches containing commit
No related tags found
Tags containing commit
2 merge requests
!7452
Issue #1797438. HTML5 validation is preventing form submit and not fully...
,
!789
Issue #3210310: Adjust Database API to remove deprecated Drupal 9 code in Drupal 10
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
core/modules/comment/comment.install
+7
-0
7 additions, 0 deletions
core/modules/comment/comment.install
core/modules/comment/src/CommentViewsData.php
+60
-6
60 additions, 6 deletions
core/modules/comment/src/CommentViewsData.php
with
67 additions
and
6 deletions
core/modules/comment/comment.install
+
7
−
0
View file @
187a3c54
...
@@ -127,3 +127,10 @@ function comment_update_8001() {
...
@@ -127,3 +127,10 @@ function comment_update_8001() {
/**
/**
* @} End of "addtogroup updates-8.0.0-rc".
* @} End of "addtogroup updates-8.0.0-rc".
*/
*/
/**
* Clear caches to fix Comment Views context filter.
*/
function
comment_update_8002
()
{
// Empty update to cause a cache flush.
}
This diff is collapsed.
Click to expand it.
core/modules/comment/src/CommentViewsData.php
+
60
−
6
View file @
187a3c54
...
@@ -40,11 +40,65 @@ public function getViewsData() {
...
@@ -40,11 +40,65 @@ public function getViewsData() {
$data
[
'comment_field_data'
][
'created'
][
'title'
]
=
$this
->
t
(
'Post date'
);
$data
[
'comment_field_data'
][
'created'
][
'title'
]
=
$this
->
t
(
'Post date'
);
$data
[
'comment_field_data'
][
'created'
][
'help'
]
=
$this
->
t
(
'Date and time of when the comment was created.'
);
$data
[
'comment_field_data'
][
'created'
][
'help'
]
=
$this
->
t
(
'Date and time of when the comment was created.'
);
$data
[
'comment_field_data'
][
'created_fulldata'
]
=
array
(
'title'
=>
$this
->
t
(
'Created date'
),
'help'
=>
$this
->
t
(
'Date in the form of CCYYMMDD.'
),
'argument'
=>
array
(
'field'
=>
'created'
,
'id'
=>
'date_fulldate'
,
),
);
$data
[
'comment_field_data'
][
'created_year_month'
]
=
array
(
'title'
=>
$this
->
t
(
'Created year + month'
),
'help'
=>
$this
->
t
(
'Date in the form of YYYYMM.'
),
'argument'
=>
array
(
'field'
=>
'created'
,
'id'
=>
'date_year_month'
,
),
);
$data
[
'comment_field_data'
][
'created_year'
]
=
array
(
'title'
=>
$this
->
t
(
'Created year'
),
'help'
=>
$this
->
t
(
'Date in the form of YYYY.'
),
'argument'
=>
array
(
'field'
=>
'created'
,
'id'
=>
'date_year'
,
),
);
$data
[
'comment_field_data'
][
'created_month'
]
=
array
(
'title'
=>
$this
->
t
(
'Created month'
),
'help'
=>
$this
->
t
(
'Date in the form of MM (01 - 12).'
),
'argument'
=>
array
(
'field'
=>
'created'
,
'id'
=>
'date_month'
,
),
);
$data
[
'comment_field_data'
][
'created_day'
]
=
array
(
'title'
=>
$this
->
t
(
'Created day'
),
'help'
=>
$this
->
t
(
'Date in the form of DD (01 - 31).'
),
'argument'
=>
array
(
'field'
=>
'created'
,
'id'
=>
'date_day'
,
),
);
$data
[
'comment_field_data'
][
'created_week'
]
=
array
(
'title'
=>
$this
->
t
(
'Created week'
),
'help'
=>
$this
->
t
(
'Date in the form of WW (01 - 53).'
),
'argument'
=>
array
(
'field'
=>
'created'
,
'id'
=>
'date_week'
,
),
);
$data
[
'comment_field_data'
][
'changed'
][
'title'
]
=
$this
->
t
(
'Updated date'
);
$data
[
'comment_field_data'
][
'changed'
][
'title'
]
=
$this
->
t
(
'Updated date'
);
$data
[
'comment_field_data'
][
'changed'
][
'help'
]
=
$this
->
t
(
'Date and time of when the comment was last updated.'
);
$data
[
'comment_field_data'
][
'changed'
][
'help'
]
=
$this
->
t
(
'Date and time of when the comment was last updated.'
);
$data
[
'comment_field_data'
][
'changed_fulldata'
]
=
array
(
$data
[
'comment_field_data'
][
'changed_fulldata'
]
=
array
(
'title'
=>
$this
->
t
(
'C
reat
ed date'
),
'title'
=>
$this
->
t
(
'C
hang
ed date'
),
'help'
=>
$this
->
t
(
'Date in the form of CCYYMMDD.'
),
'help'
=>
$this
->
t
(
'Date in the form of CCYYMMDD.'
),
'argument'
=>
array
(
'argument'
=>
array
(
'field'
=>
'changed'
,
'field'
=>
'changed'
,
...
@@ -53,7 +107,7 @@ public function getViewsData() {
...
@@ -53,7 +107,7 @@ public function getViewsData() {
);
);
$data
[
'comment_field_data'
][
'changed_year_month'
]
=
array
(
$data
[
'comment_field_data'
][
'changed_year_month'
]
=
array
(
'title'
=>
$this
->
t
(
'C
reat
ed year + month'
),
'title'
=>
$this
->
t
(
'C
hang
ed year + month'
),
'help'
=>
$this
->
t
(
'Date in the form of YYYYMM.'
),
'help'
=>
$this
->
t
(
'Date in the form of YYYYMM.'
),
'argument'
=>
array
(
'argument'
=>
array
(
'field'
=>
'changed'
,
'field'
=>
'changed'
,
...
@@ -62,7 +116,7 @@ public function getViewsData() {
...
@@ -62,7 +116,7 @@ public function getViewsData() {
);
);
$data
[
'comment_field_data'
][
'changed_year'
]
=
array
(
$data
[
'comment_field_data'
][
'changed_year'
]
=
array
(
'title'
=>
$this
->
t
(
'C
reat
ed year'
),
'title'
=>
$this
->
t
(
'C
hang
ed year'
),
'help'
=>
$this
->
t
(
'Date in the form of YYYY.'
),
'help'
=>
$this
->
t
(
'Date in the form of YYYY.'
),
'argument'
=>
array
(
'argument'
=>
array
(
'field'
=>
'changed'
,
'field'
=>
'changed'
,
...
@@ -71,7 +125,7 @@ public function getViewsData() {
...
@@ -71,7 +125,7 @@ public function getViewsData() {
);
);
$data
[
'comment_field_data'
][
'changed_month'
]
=
array
(
$data
[
'comment_field_data'
][
'changed_month'
]
=
array
(
'title'
=>
$this
->
t
(
'C
reat
ed month'
),
'title'
=>
$this
->
t
(
'C
hang
ed month'
),
'help'
=>
$this
->
t
(
'Date in the form of MM (01 - 12).'
),
'help'
=>
$this
->
t
(
'Date in the form of MM (01 - 12).'
),
'argument'
=>
array
(
'argument'
=>
array
(
'field'
=>
'changed'
,
'field'
=>
'changed'
,
...
@@ -80,7 +134,7 @@ public function getViewsData() {
...
@@ -80,7 +134,7 @@ public function getViewsData() {
);
);
$data
[
'comment_field_data'
][
'changed_day'
]
=
array
(
$data
[
'comment_field_data'
][
'changed_day'
]
=
array
(
'title'
=>
$this
->
t
(
'C
reat
ed day'
),
'title'
=>
$this
->
t
(
'C
hang
ed day'
),
'help'
=>
$this
->
t
(
'Date in the form of DD (01 - 31).'
),
'help'
=>
$this
->
t
(
'Date in the form of DD (01 - 31).'
),
'argument'
=>
array
(
'argument'
=>
array
(
'field'
=>
'changed'
,
'field'
=>
'changed'
,
...
@@ -89,7 +143,7 @@ public function getViewsData() {
...
@@ -89,7 +143,7 @@ public function getViewsData() {
);
);
$data
[
'comment_field_data'
][
'changed_week'
]
=
array
(
$data
[
'comment_field_data'
][
'changed_week'
]
=
array
(
'title'
=>
$this
->
t
(
'C
reat
ed week'
),
'title'
=>
$this
->
t
(
'C
hang
ed week'
),
'help'
=>
$this
->
t
(
'Date in the form of WW (01 - 53).'
),
'help'
=>
$this
->
t
(
'Date in the form of WW (01 - 53).'
),
'argument'
=>
array
(
'argument'
=>
array
(
'field'
=>
'changed'
,
'field'
=>
'changed'
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment