Unverified Commit 145d174f authored by alexpott's avatar alexpott
Browse files

Issue #2969231 by quietone, NickDickinsonWilde, joachim, xjm: errors in...

Issue #2969231 by quietone, NickDickinsonWilde, joachim, xjm: errors in migration process configuration don't give a clear message

(cherry picked from commit 93545bd5)
parent cc28bd2d
......@@ -386,6 +386,10 @@ protected function getProcessNormalized(array $process) {
if (isset($configuration['plugin'])) {
$configuration = [$configuration];
}
if (!is_array($configuration)) {
$migration_id = $this->getPluginId();
throw new MigrateException("Invalid process for destination '$destination' in migration '$migration_id'");
}
$normalized_configurations[$destination] = $configuration;
}
return $normalized_configurations;
......
......@@ -42,23 +42,64 @@ public function testGetProcessPluginsException() {
}
/**
* Tests Migration::getDestinationPlugin()
* Tests Migration::getProcessPlugins()
*
* @covers ::getDestinationPlugin
* @param array $process
* The migration process pipeline.
*
* @covers ::getProcessPlugins
*
* @dataProvider getProcessPluginsExceptionMessageProvider
*/
public function testGetProcessPluginsExceptionMessage() {
public function testGetProcessPluginsExceptionMessage(array $process) {
// Test with an invalid process pipeline.
$plugin_definition = [
'process' => [
'dest1' => 123,
],
'id' => 'foo',
'process' => $process,
];
$migration = \Drupal::service('plugin.manager.migration')->createStubMigration($plugin_definition);
reset($process);
$destination = key(($process));
$migration = \Drupal::service('plugin.manager.migration')
->createStubMigration($plugin_definition);
$this->expectException(MigrateException::class);
$this->expectExceptionMessage("Process configuration for 'dest1' must be an array");
$this->expectExceptionMessage("Invalid process for destination '$destination' in migration 'foo'");
$migration->getProcessPlugins();
}
/**
* Provides data for testing invalid process pipeline.
*/
public function getProcessPluginsExceptionMessageProvider() {
return [
[
'Null' =>
[
'dest' => NULL,
],
],
[
'boolean' =>
[
'dest' => TRUE,
],
],
[
'integer' =>
[
'dest' => 2370,
],
],
[
'float' =>
[
'dest' => 1.61,
],
],
];
}
/**
* Tests Migration::getMigrationDependencies()
*
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment