Issue #3495638 by nikolay shapovalov, smustgrave, nicxvan: Move helpers in...

Issue #3495638 by nikolay shapovalov, smustgrave, nicxvan: Move helpers in workflow_type_test.module and delete it

core/.phpstan-baseline.php

@@ -53223,12 +53223,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/modules/workflows/tests/modules/workflow_type_test/src/Plugin/WorkflowType/WorkflowCustomAccessType.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Function workflow_type_test_set_definitions\\(\\) has no return type specified\\.$#',
-	'identifier' => 'missingType.return',
-	'count' => 1,
-	'path' => __DIR__ . '/modules/workflows/tests/modules/workflow_type_test/workflow_type_test.module',
-];
 $ignoreErrors[] = [
 	'message' => '#^Method Drupal\\\\Tests\\\\workflows\\\\Functional\\\\Rest\\\\WorkflowJsonAnonTest\\:\\:assertAuthenticationEdgeCases\\(\\) has no return type specified\\.$#',
 	'identifier' => 'missingType.return',

core/modules/workflows/tests/modules/workflow_type_test/workflow_type_test.module

-<?php
-
-/**
- * @file
- * Module file for workflow_type_test.
- */
-
-declare(strict_types=1);
-
-/**
- * Sets the type plugin definitions override and clear the cache.
- *
- * @param array $definitions
- *   Definitions to set.
- */
-function workflow_type_test_set_definitions($definitions) {
-  \Drupal::state()->set('workflow_type_test.plugin_definitions', $definitions);
-  \Drupal::service('plugin.manager.workflows.type')->clearCachedDefinitions();
-}

core/modules/workflows/tests/src/Kernel/WorkflowAccessControlHandlerTest.php

@@ -88,7 +88,8 @@ public function testCheckCreateAccess(): void {
 
     // Remove all plugin types and ensure not even the admin user is allowed to
     // create a workflow.
-    workflow_type_test_set_definitions([]);
+    $this->container->get('state')->set('workflow_type_test.plugin_definitions', []);
+    $this->container->get('plugin.manager.workflows.type')->clearCachedDefinitions();
     $this->accessControlHandler->resetCache();
     $this->assertEquals(
       AccessResult::neutral()