Skip to content
Snippets Groups Projects
Unverified Commit 00b74b0c authored by Lauri Timmanee's avatar Lauri Timmanee
Browse files

Issue #3333401 by nicxvan, bnjmnm: Pager h4 causes accessibility flag on many pages

(cherry picked from commit 01de0a84)
parent af768ada
No related branches found
No related tags found
11 merge requests!8506Draft: Issue #3456536 by ibrahim tameme,!5646Issue #3350972 by nod_: [random test failure]...,!5600Issue #3350972 by nod_: [random test failure]...,!5343Issue #3305066 by quietone, Rename RedirectLeadingSlashesSubscriber,!3603#ISSUE 3346218 Add a different message on edit comment,!3555Issue #2473873: Views entity operations lack cacheability support, resulting in incorrect dropbuttons,!3494Issue #3327018 by Spokje, longwave, xjm, mondrake: Update PHPStan to 1.9.3 and...,!3410Issue #3340128: UserLoginForm::submitForm has some dead code,!3389Issue #3325184 by Spokje, andypost, xjm, smustgrave: $this->configFactory is...,!3381Issue #3332363: Refactor Claro's menus-and-lists stylesheet,!3307Issue #3326193: CKEditor 5 can grow past the viewport when there is a lot of content
...@@ -33,8 +33,7 @@ ...@@ -33,8 +33,7 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}
......
...@@ -13,8 +13,7 @@ ...@@ -13,8 +13,7 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="js-pager__items"> <ul class="js-pager__items">
{% if items.previous %} {% if items.previous %}
<li> <li>
......
...@@ -11,8 +11,7 @@ ...@@ -11,8 +11,7 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="pager__heading visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{% if items.previous %} {% if items.previous %}
<li class="pager__item pager__item--previous"> <li class="pager__item pager__item--previous">
......
...@@ -35,8 +35,7 @@ ...@@ -35,8 +35,7 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}
......
...@@ -18,8 +18,7 @@ ...@@ -18,8 +18,7 @@
] ]
%} %}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav{{ attributes.addClass('pager').setAttribute('role', 'navigation').setAttribute('aria-labelledby', heading_id) }}> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4{{ title_attributes.addClass('visually-hidden').setAttribute('id', heading_id) }}>{{ 'Pagination'|t }}</h4>
<ul{{ content_attributes.addClass('pager__items', 'js-pager__items') }}> <ul{{ content_attributes.addClass('pager__items', 'js-pager__items') }}>
{% if items.previous %} {% if items.previous %}
{% apply spaceless %} {% apply spaceless %}
......
...@@ -31,8 +31,7 @@ ...@@ -31,8 +31,7 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager layout--content-medium" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}
......
...@@ -11,8 +11,7 @@ ...@@ -11,8 +11,7 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print previous item if we are not on the first page. #} {# Print previous item if we are not on the first page. #}
{% if items.previous %} {% if items.previous %}
......
...@@ -31,8 +31,7 @@ ...@@ -31,8 +31,7 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}
......
...@@ -11,8 +11,7 @@ ...@@ -11,8 +11,7 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="pager__heading visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{% if items.previous %} {% if items.previous %}
<li class="pager__item pager__item--previous"> <li class="pager__item pager__item--previous">
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment