Implemented ct-typography into starshot components.
I've reviewed the designs as of 2nd September 2024 and grouped any identical fonts (there were only two) into generic heading / button typography. The remainder have been given a custom typography name.
The line heights are slightly different to the design - I have rounded them to the nearest even number.
Merge request reports
Activity
assigned to @alan.cole
mentioned in merge request !35 (merged)
requested review from @kepol
@alan.cole Can you please merge this MR with updated changes? So I can continue with other components with this latest font update.
@Bhut.Avani I'm waiting on a review from @kepol - If you like you can create a branch off this one and continue working. When this one gets merged you can then create the MR pointing at the 1.0.x branch.
-
@alan.cole Thanks for quick response. now I will create new branch from this and continue with the other component styling.
-
@alan.cole I have created other MR for other component. Please review 37
added 24 commits
-
983e9724...e4a886a8 - 23 commits from branch
1.0.x - 80b8d5e7 - Merge branch '1.0.x' into feature/civictheme-font-integration
-
983e9724...e4a886a8 - 23 commits from branch
Compared against Figma and it looks pretty close.
Not typography, but there is the padding issue for the CTA which was mentioned before so perhaps it's being handled separately.
Another thing that's not typography is that in storybook, everything is so big... I'm unclear why. Things were also big when I tried testing something in XB.
But, for this MR, this seems fine to me.
