Skip to content
Snippets Groups Projects

issue #15750430: Create mobile CSS for updated starshot-testimonial-card,...

Merged issue #15750430: Create mobile CSS for updated starshot-testimonial-card,...
All threads resolved!
All threads resolved!

issue #15750430: Create mobile CSS for updated starshot-testimonial-card, starshot-listing-testimonial components

Closes #3471093

Merge request reports

Pipeline #271537 passed

Pipeline passed for e231d9ce on issue:3471093-create-mobile-css

Merged by Alan ColeAlan Cole 7 months ago (Sep 3, 2024 1:10am UTC)

Merge details

  • Changes merged into 1.0.x with 629ef70e (commits were squashed).
  • Did not delete the source branch.

Pipeline #272036 passed

Pipeline passed for 629ef70e on 1.0.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alan Cole requested changes

    requested changes

  • avani.bhut resolved all threads

    resolved all threads

  • avani.bhut added 1 commit

    added 1 commit

    Compare with previous version

  • avani.bhut added 1 commit

    added 1 commit

    Compare with previous version

  • Alan Cole requested review from @alan.cole

    requested review from @alan.cole

  • Alan Cole approved this merge request

    approved this merge request

  • Alan Cole requested review from @kepol

    requested review from @kepol

  • Thanks @Bhut.Avani,

    Based on some of the font work here, I've implemented the remaining fonts to hopefully make the other components easier to style for mobile.

    I've reviewed the designs as of yesterday and grouped any identical fonts (there were only two) into generic heading / button typography. The remainder have been given a custom typography name.

    Please see !36 (merged) for where this work has happened.

    I intend to merge this MR, and make adjustments to use the font names from that MR, but with the mobile designs from this one.

    Thanks again!

    Edited by Alan Cole
  • merged

  • Please register or sign in to reply
    Loading