Skip to content

Visual cleanup for menu

Harumi Jangrequested to merge
issue/canvas-3548322:clean-improved-list-fields into 1.x

[#3548322]

This MR:

  • Removes hard-coded "Revision log message" removal in the FE code. This will be addressed in a backend issue that I will open up that @wimleers requested.

  • Removes the activeChild check where a label would be grey if it had a child suggestion that was linked to the prop.

    • Checked with design -- just indicating the selected item is fine. no need for parent to have visual cue.

  • Removes the code for the left space of a label where an icon would go. I originally added this so the labels would still line up vertically even with an icon, but it adds extra space on the left that makes it look off if there is a menu of one item.

    • Checked with design -- it's ok for the icon to line up with the rest of the labels instead. The selected item is already visually different as its disabled and has a check next to it.

  • image.png

  • image.png

Edited by Harumi Jang

Merge request reports