Override datetime.time service instead.

Christian López Espínolarequested to merge
issue/canvas-3587922:3587922-hardcode-time into 1.x

Change \Drupal\Tests\canvas\Kernel\Traits\PredictableImageStyleItokTestTrait instead of the replacements dance:

  • Consistent with ClientDataToEntityConverterTest and AutoSaveManagerTest in terms of overriding the datetime.time service.
  • Consistent with multiple other kernel tests on only replacing ::SITE_DIR_BASE_URL::
  • Future-proof if we need to test other endpoints allowing image uploads (we need \Drupal\Tests\canvas\Kernel\Traits\PredictableImageStyleItokTestTrait anyway).
  • IMHO readability, but that's subjective.

Testing instructions

  • Tests are green

Closes #3587922

Merge request reports