Skip to content
Snippets Groups Projects

Issue #3341224: Always catch \Throwable, not \Exception and always pass the old exception when re-throwing.

Merged Issue #3341224: Always catch \Throwable, not \Exception and always pass the old exception when re-throwing.
All threads resolved!
All threads resolved!
1 file
+ 2
0
Compare changes
  • Side-by-side
  • Inline
+ 2
0
@@ -9,6 +9,7 @@ build:
@@ -9,6 +9,7 @@ build:
# Run code quality checks.
# Run code quality checks.
container_command.commit-checks:
container_command.commit-checks:
commands:
commands:
 
- cat /var/www/html/core/scripts/dev/commit-code-check.sh
# Copy core's checking script into this contrib module.
# Copy core's checking script into this contrib module.
- "cp /var/www/html/core/scripts/dev/commit-code-check.sh modules/contrib/automatic_updates/"
- "cp /var/www/html/core/scripts/dev/commit-code-check.sh modules/contrib/automatic_updates/"
# Comply with core's checking script file permissions expectations.
# Comply with core's checking script file permissions expectations.
@@ -36,6 +37,7 @@ build:
@@ -36,6 +37,7 @@ build:
# Ensure we have the full path to PHPStan.
# Ensure we have the full path to PHPStan.
- sed -i "s/vendor\/bin\/phpstan/\/var\/www\/html\/vendor\/bin\/phpstan/" modules/contrib/automatic_updates/commit-code-check.sh
- sed -i "s/vendor\/bin\/phpstan/\/var\/www\/html\/vendor\/bin\/phpstan/" modules/contrib/automatic_updates/commit-code-check.sh
# After all of the shenanigans above, we're finally ready to run core's `commit-code-check.sh`! :)
# After all of the shenanigans above, we're finally ready to run core's `commit-code-check.sh`! :)
 
- cat modules/contrib/automatic_updates/commit-code-check.sh
- "modules/contrib/automatic_updates/commit-code-check.sh --drupalci"
- "modules/contrib/automatic_updates/commit-code-check.sh --drupalci"
# Restore the original permissions.
# Restore the original permissions.
- chmod 777 modules/contrib/automatic_updates/
- chmod 777 modules/contrib/automatic_updates/
Loading