Skip to content
Snippets Groups Projects

Issue #3341224: Always catch \Throwable, not \Exception and always pass the old exception when re-throwing.

Merged Issue #3341224: Always catch \Throwable, not \Exception and always pass the old exception when re-throwing.
issue/automatic_updates-3341224:3341224-always-catch-throwable-30x into 3.0.x
All threads resolved!
Merged omkar podey requested to merge issue/automatic_updates-3341224:3341224-always-catch-throwable-30x into 3.0.x
All threads resolved!
Compare
and
3 files
+ 8
− 8
Compare changes
  • Side-by-side
  • Inline
Files
3
package_manager/src/Validator/ComposerSettingsValidator.php
+ 2
− 2
@@ -45,8 +45,8 @@ final class ComposerSettingsValidator implements EventSubscriberInterface {
try {
$setting = (int) $this->inspector->getConfig('secure-http', $dir);
}
catch (\Exception $exception) {
$event->addErrorFromThrowable($exception, $this->t('Unable to determine Composer <code>secure-http</code> setting.'));
catch (\Throwable $throwable) {
$event->addErrorFromThrowable($throwable, $this->t('Unable to determine Composer <code>secure-http</code> setting.'));
return;
}
if ($setting !== 1) {