Skip to content
Snippets Groups Projects

Issue #3304365: Do not check excluded folders for symlinks

Merged Adam G-H requested to merge issue/automatic_updates-3304365:3304365-do-not-check into 8.x-2.x
1 file
+ 13
12
Compare changes
  • Side-by-side
  • Inline
@@ -54,8 +54,16 @@ class SymlinkValidatorTest extends PackageManagerKernelTestBase {
*/
public function providerSymlink(): array {
return [
'no symlinks' => [FALSE],
'symlinks' => [TRUE],
'no symlinks' => [
FALSE,
[],
],
'symlinks' => [
TRUE,
[
ValidationResult::createError(['Symlinks were found.']),
],
],
];
}
@@ -64,10 +72,12 @@ class SymlinkValidatorTest extends PackageManagerKernelTestBase {
*
* @param bool $symlinks_exist
* Whether or not the precondition will detect symlinks.
* @param \Drupal\package_manager\ValidationResult[] $expected_results
* The expected validation results.
*
* @dataProvider providerSymlink
*/
public function testSymlink(bool $symlinks_exist): void {
public function testSymlink(bool $symlinks_exist, array $expected_results): void {
$add_ignored_path = function (CollectIgnoredPathsEvent $event): void {
$event->add(['ignore/me']);
};
@@ -89,15 +99,6 @@ class SymlinkValidatorTest extends PackageManagerKernelTestBase {
})
->shouldBeCalled();
if ($symlinks_exist) {
$expected_results = [
ValidationResult::createError(['Symlinks were found.']),
];
}
else {
$expected_results = [];
}
$this->assertStatusCheckResults($expected_results);
$this->assertResults($expected_results, PreCreateEvent::class);
Loading