Issue #3304365: Do not check excluded folders for symlinks
2 unresolved threads
Merge request reports
Activity
added 1 commit
- fbf9c32f - revert $return_as_object in favor of deprecating in another issue
added 5 commits
-
fbf9c32f...0d680aae - 3 commits from branch
project:8.x-2.x - 2605b300 - Merge branch '8.x-2.x' into 3304365-do-not-check
- 9fddbce7 - Run the validator later
-
fbf9c32f...0d680aae - 3 commits from branch
added 4 commits
-
9fddbce7...ca95d870 - 2 commits from branch
project:8.x-2.x - 9816be97 - Merge branch '8.x-2.x' into 3304365-do-not-check
- bfb9642c - sketch in api
-
9fddbce7...ca95d870 - 2 commits from branch
added 3 commits
added 1 commit
- 34bfefa3 - Make PathExclusionsTrait account for CollectIgnoredPathsEvent
added 1 commit
- 15c98f83 - Make all excluders listen only to CollectIgnoredPathsEvent
added 1 commit
- 50288564 - Remove a deprecated call to excludePath() in Stage::apply
added 1 commit
- 42d3a2dd - Make SymlinkValidator pass ignored paths to the precondition
added 1 commit
- e2d0bcaa - Explicitly deprecate certain thing passed to PathExclusionsTrait
1 <?php 2 3 namespace Drupal\package_manager\Event; 4 5 use Drupal\package_manager\Stage; 6 use PhpTuf\ComposerStager\Domain\Value\PathList\PathListInterface; 7 use PhpTuf\ComposerStager\Infrastructure\Value\PathList\PathList; 8 9 /** 10 * Defines an event that collects ignored paths. 11 * 12 * Ignored paths are completely ignored by Composer Stager. They are never 13 * copied into the staging area from the active directory, or vice-versa. -
I guess my point is what actually happens depends on the logic of the subscriber. I don't to get give the impression the fire the event 1x for the whole lifecycle of the update and if you add the exclusion it will be excluded in all stages. That depends on you ignoring the state of the stage
added 1 commit
- 843f25ea - Add explicit test coverage of StatusCheckTrait
6 use Drupal\package_manager\Event\StatusCheckEvent; 7 use Drupal\package_manager\StatusCheckTrait; 8 9 /** 10 * @covers \Drupal\package_manager\StatusCheckTrait 11 * 12 * @group package_manager 13 */ 14 class StatusCheckTraitTest extends PackageManagerKernelTestBase { 15 16 use StatusCheckTrait; 17 18 /** 19 * Tests that StatusCheckTrait will collect ignored paths. 20 */ 21 public function testIgnoredPathsCollected(): void { added 6 commits
- ec088ad7 - Pass exclusions to precondition
- fbf9c32f - revert $return_as_object in favor of deprecating in another issue
- 2605b300 - Merge branch '8.x-2.x' into 3304365-do-not-check
- 9fddbce7 - Run the validator later
- 658a6b49 - Merge branch '3304365-do-not-check' of...
- 3f20d144 - Add a test confirming that PreCreate and PreApply collect ignored paths
Toggle commit listadded 3 commits
-
35f7a4e7...0bcd417a - 2 commits from branch
project:8.x-2.x - ac04824c - Merge branch '8.x-2.x' into 3304365-do-not-check
-
35f7a4e7...0bcd417a - 2 commits from branch
Please register or sign in to reply