Skip to content
Snippets Groups Projects

UX improvements for site builders using the AI Automators

Merged Paul Smith requested to merge issue/ai-3491583:3491583-ux-of-ai into 1.0.x
1 unresolved thread

Hide sections of the UI if the module required to use them is not enabled, or a developer has not forced them to display. #3491583

Closes #3491583

Merge request reports

Approved by
Code Quality is loading
Test summary results are being parsed

Merged by Marcus JohanssonMarcus Johansson 3 months ago (Dec 6, 2024 9:50am UTC)

Merge details

  • Changes merged into 1.0.x with 0c42a89e (commits were squashed).
  • Did not delete the source branch.
  • Auto-merge enabled

Pipeline #361067 canceled

Pipeline canceled for 0c42a89e on 1.0.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
15 * Checks if access to advanced AI Automator features should be granted.
16 */
17 final class AutomatorAdvancedAccessChecker implements AccessInterface {
18
19 /**
20 * Constructs an AutomatorAdvancedAccessChecker object.
21 */
22 public function __construct(
23 private readonly ModuleHandlerInterface $moduleHandler,
24 ) {}
25
26 /**
27 * Access callback.
28 */
29 public function access(Route $route, AccountInterface $account): AccessResult {
30 if ($this->moduleHandler->moduleExists('ai_ckeditor') || Settings::get('ai_automator_advanced_mode_enabled', FALSE)) {
  • This is great! The only comment on this row and in the install text under:

    I think its enough with the settings here - most people that install the AI CKEditor will just use the default built in plugins, that doesn't use Automators. Since we will add more "consumers" of the custom entities, its fine that this is purely for developers at the moment and a problem how we move to builder once we have more modules using it.

  • No, I don't think that's a good idea: it makes assumptions about how other people want to use the module and not all of them will have the ability to update the settings.php. I agree that all the overhead of the AI CK Editor Integration/AI Automator Chains stuff is going to be too much for most users, but if we're not going to move it into its own module that they can enable or disable as they wish I don't think the solution is to hide it when it's physically possible that they can use it.

  • Please register or sign in to reply
  • Paul Smith added 6 commits

    added 6 commits

    • ce3783da - Update README with accurate description and dependencies. #3491583
    • c04d219d - Delete obsolete and incomplete documentation refering to previous version of this module. #3491583
    • e19555d4 - Fix broken path in mkdocs.yml. #3491583
    • 0c254293 - Move Automator Chain Type paths to be under the AI Core parent menu so menu...
    • 812ed1fb - Document the use of the AI Automators module. #3491583
    • 91b771b4 - Fix typo in pth and move sub-module instructions into the correct menu. #3491583

    Compare with previous version

  • Paul Smith added 1 commit

    added 1 commit

    Compare with previous version

  • Paul Smith added 1 commit

    added 1 commit

    Compare with previous version

  • Paul Smith marked this merge request as ready

    marked this merge request as ready

  • Marcus Johansson approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading