Skip to content
Snippets Groups Projects

Resolve #3456199 "AI validations submodule"

Merged wouters_f requested to merge issue/ai-3456199:3456199-aivalidations-for-smart into 1.0.x

Closes #3456199

Merge request reports

Code Quality is loading
Test summary results are being parsed

Merged by Marcus JohanssonMarcus Johansson 9 months ago (Jul 18, 2024 9:12am UTC)

Loading

Pipeline #227666 passed with warnings

Pipeline passed with warnings for f8051012 on 1.0.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tried testing the functionality on a D10.3 but ended up with a fatal error in AiTextConstraintValidator.php Also added some additional remarks.

  • 1 <?php
  • The dependency injection you should look through, let me know if you need help with it.

    The prompt you can decide how you want it to work, my test there was just theoretical, so if your current implementation works well, we can keep it.

    The module file you can remove, its not needed since Drupal 8.

  • Marcus Johansson requested changes

    requested changes

  • wouters_f added 63 commits

    added 63 commits

    • 3d77ca49...3c3591f9 - 53 earlier commits
    • ffab374d - Issue #3460736 by Marcus_Johansson: Refactor all files to use generictype files
    • b26597cf - Issue #3460736 by Marcus_Johansson: Refactor all files to use generictype files
    • a26f725e - Issue #3460736 by Marcus_Johansson: Refactor all files to use generictype files
    • 21abcab3 - Issue #3460753: Embeddings should allow to specify the number of dimensions
    • c0795496 - Issue #3460781 by Marcus_Johansson: Base64 response does not work on OpenAI...
    • 3638aad9 - Phpcs fixes
    • 33be1bce - Phpcs fixes
    • 6cd972e9 - Issue #3456395 by Marcus_Johansson, wouters_f: Remove stream parameter from...
    • 96ae6ee0 - Streamed changes and changes to how the config is built
    • 35056932 - Merge of Chat Stream Interface

    Compare with previous version

  • wouters_f added 1 commit

    added 1 commit

    Compare with previous version

  • wouters_f added 1 commit

    added 1 commit

    • 02a99c06 - [3456199] tested with queen elisabeth, also added in a nice default

    Compare with previous version

  • wouters_f added 68 commits

    added 68 commits

    Compare with previous version

  • wouters_f added 1 commit

    added 1 commit

    Compare with previous version

  • wouters_f added 1 commit

    added 1 commit

    • 347dcee4 - [3456199] Check if default is set when configuring validations

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading