Skip to content
Snippets Groups Projects
Commit ae61926b authored by omkar podey's avatar omkar podey Committed by Adam G-H
Browse files

Issue #3351212 by omkar.podey, phenaproxima, Wim Leers, tedbow: Remove all of...

Issue #3351212 by omkar.podey, phenaproxima, Wim Leers, tedbow: Remove all of our PHPStan `ignoreErrors` entries AND ignore PHPStan errors caused by upstream changes in core
parent 4c3fc538
No related branches found
No related tags found
No related merge requests found
...@@ -263,6 +263,9 @@ class FixtureManipulatorTest extends PackageManagerKernelTestBase { ...@@ -263,6 +263,9 @@ class FixtureManipulatorTest extends PackageManagerKernelTestBase {
/** /**
* {@inheritdoc} * {@inheritdoc}
*
* @todo Remove the line below when https://github.com/phpstan/phpstan-phpunit/issues/187 is fixed.
* @phpstan-ignore-next-line
*/ */
protected function tearDown(): void { protected function tearDown(): void {
try { try {
......
...@@ -420,6 +420,7 @@ abstract class PackageManagerKernelTestBase extends KernelTestBase { ...@@ -420,6 +420,7 @@ abstract class PackageManagerKernelTestBase extends KernelTestBase {
$this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::CRITICAL), 'Package Manager logged critical errors.'); $this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::CRITICAL), 'Package Manager logged critical errors.');
$this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::ERROR), 'Package Manager logged errors.'); $this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::ERROR), 'Package Manager logged errors.');
$this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::WARNING), 'Package Manager logged warnings.'); $this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::WARNING), 'Package Manager logged warnings.');
parent::tearDown();
} }
/** /**
......
...@@ -5,6 +5,5 @@ parameters: ...@@ -5,6 +5,5 @@ parameters:
ignoreErrors: ignoreErrors:
# Drupal core's PHPStan config file ignores the non-anonymous variant of this. # Drupal core's PHPStan config file ignores the non-anonymous variant of this.
- "#^Anonymous class extends @internal class#" - "#^Anonymous class extends @internal class#"
- "#^Missing call to parent::tearDown.* method#"
# Drupal core needs to ignore more things than we need to! # Drupal core needs to ignore more things than we need to!
reportUnmatchedIgnoredErrors: false reportUnmatchedIgnoredErrors: false
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment