From ae61926b2a2f8046d69b6e98b760948bf1f0be1f Mon Sep 17 00:00:00 2001
From: omkar podey <58183-omkar.podey@users.noreply.drupalcode.org>
Date: Tue, 23 May 2023 17:26:33 +0000
Subject: [PATCH] Issue #3351212 by omkar.podey, phenaproxima, Wim Leers,
tedbow: Remove all of our PHPStan `ignoreErrors` entries AND ignore PHPStan
errors caused by upstream changes in core
---
package_manager/tests/src/Kernel/FixtureManipulatorTest.php | 3 +++
.../tests/src/Kernel/PackageManagerKernelTestBase.php | 1 +
phpstan.neon.dist | 1 -
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/package_manager/tests/src/Kernel/FixtureManipulatorTest.php b/package_manager/tests/src/Kernel/FixtureManipulatorTest.php
index 679e308be6..7c6c9da198 100644
--- a/package_manager/tests/src/Kernel/FixtureManipulatorTest.php
+++ b/package_manager/tests/src/Kernel/FixtureManipulatorTest.php
@@ -263,6 +263,9 @@ class FixtureManipulatorTest extends PackageManagerKernelTestBase {
/**
* {@inheritdoc}
+ *
+ * @todo Remove the line below when https://github.com/phpstan/phpstan-phpunit/issues/187 is fixed.
+ * @phpstan-ignore-next-line
*/
protected function tearDown(): void {
try {
diff --git a/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php b/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php
index 8a6969b487..4d222646e7 100644
--- a/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php
+++ b/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php
@@ -420,6 +420,7 @@ abstract class PackageManagerKernelTestBase extends KernelTestBase {
$this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::CRITICAL), 'Package Manager logged critical errors.');
$this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::ERROR), 'Package Manager logged errors.');
$this->assertFalse($this->failureLogger->hasRecords(RfcLogLevel::WARNING), 'Package Manager logged warnings.');
+ parent::tearDown();
}
/**
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
index 30d88bf1b9..fd16bd0054 100644
--- a/phpstan.neon.dist
+++ b/phpstan.neon.dist
@@ -5,6 +5,5 @@ parameters:
ignoreErrors:
# Drupal core's PHPStan config file ignores the non-anonymous variant of this.
- "#^Anonymous class extends @internal class#"
- - "#^Missing call to parent::tearDown.* method#"
# Drupal core needs to ignore more things than we need to!
reportUnmatchedIgnoredErrors: false
--
GitLab