follow-up: #3622036 The documentation describes the availability endpoints as cacheable documents and never names the permission and channel gate they carry
Follow-up to the documentation change merged as 0dd3e0f2, on the same issue rather than a new one: nothing else open touches these files, and the two findings came out of reading the routes for this report.
A private method named something it does not do. AvailabilityDocument::hasAnonymousContribution() asks whether the anonymous role holds a permission, and at its one call site it read as a question about a contribution. Renamed anonymousRoleHasPermission(), which is core's shape for the question (workflowStateHasData(), pathHasMatchingAlias(); core has ten hasPermission( and no isGranted*), and its docblock now says what it answers. Private, one caller, no other reference in the module.
A shipped comment still asking for a move that was made elsewhere. The comment above yoyaku_placement.venue_availability said the calendar's feed "is still at /booking/availability today, which is the wrong side of that line, and moving it is part of this issue" - a live TODO naming an issue that closed without the move. What survives is the part that explains the name; the judgment about a path that did not move is gone, and nothing in the module names the /availability/resource it proposed.
And the same comment called a slot a session, which the vocabulary sweep on 3618369 missed in the routing files: five comments across the calendar and placement routes. Fixed by hand, one sentence at a time. The remaining session in yoyaku_calendar.routing.yml is the HTTP session (a per-session form token), which is correct and stays.
Comments and one private name, so no behavior changes. phpcs over the module at the job's own extensions: 1099 files, no violations. phpstan level 5 from the module directory: [OK] No errors. cspell over the three files: no word that is not already in the project dictionary. No local test run: nothing here is reachable by a test, and no test named the old method.
AI-Generated: Yes (Claude Code was used to find these while checking the routes against the report, and to write the change and this description. I reviewed it before posting.)