Loading
Fix the phpcs, eslint and cspell failures left by #3615672
Closes [#3615686].
Three allow_failure jobs were red under a green pipeline badge on [#3615672]. All three are in the code that issue added; none of this changes behaviour.
phpcs — 4 errors
testImportNumbersADrawnRowAlongItsDrawing→testImportNumbersDrawnRowsAlongTheDrawing. The sniff rejects two capitals in a row and "ADrawn" has them.- Three 166-column array literals (limit 120) replaced by a
drawnPlace()helper, which also stops three rows repeating the same eight keys.
eslint — 1 error
no-use-before-define: overlay() calls toggle(), declared below it. venue-map.js and venue-map-pick.js already carry the same disable with a comment — core's config sets the rule's functions option to false, contrib CI falls back to the stricter default. The new file needed it too.
cspell — 5 words, all reworded, none added to the dictionary
behaviours,neighbour,neighbours— British spelling against the project's American spelling, includingwidestNeighbours()→widestNeighbors().undrawn,unwalked— invented words, now "a row with no drawing" and "nearest seat not yet walked".
Verified
- phpcs clean over the whole module at CI's extension set (the
.mdwarnings my wider local run showed are pre-existing across a dozen docs files and outside CI's scope). - eslint 0 errors under core's own config resolution, which is what CI uses — not the ci-templates config, whose
functions: falseis why the error could not appear locally. - cspell: the five flagged words are gone; the remaining unknowns cspell reports are already in
.cspell-project-words.txt, which is why CI never flagged them. RowPathTest,PlacePositionsTest,VenueIoTestgreen.