Resolve #3487813 "Stale rejections block transition"

Closes #3487813

src/EventSubscriber/WorkspaceApprovalNotifyEventSubscriber.php

@@ -50,7 +50,7 @@ final class WorkspaceApprovalNotifyEventSubscriber implements EventSubscriberInt
     $requests = $storage->getApprovalRequests(NULL, (string) $workspace->id());
     foreach ($requests as $request) {
       \assert($request instanceof WorkspaceApprovalRequestInterface);
-      if ($request->isPending() && $request->isApprovalRequired($event->getWorkflow())) {
+      if (!$request->isApproved() && $request->isApprovalRequired($event->getWorkflow())) {
         $data = ReviewerNotificationQueueWorker::createData($request);
         $this->queueFactory->get(ReviewerNotificationQueueWorker::ID)->createItem($data);
       }

[Marco Villegas]

I guess this is the main bit.

I am wondering if this should become a configuration option on the request type. In that way we could support approval by any reviewer, or approval by all reviewers.

Maybe that is just worth a different issue.

[Lucas Hedding]

This, in combo w/ the resave causes all requested reviewers (who haven't approved) to get a new notification.