Issue #2919482: Clean code - WorkflowItem.php

src/Plugin/Field/FieldType/WorkflowItem.php

@@ -72,40 +72,19 @@ class WorkflowItem extends ListItemBase {
     $key .= $definition['settings']['target_bundle'] ?? '';
 
     if (!isset($propertyDefinitions[$key])) {
-
-      $propertyDefinitions[$key]['value'] = DataDefinition::create('string') // @todo D8-port: or 'any'
+      $propertyDefinitions[$key]['value'] = DataDefinition::create('string')
         ->setLabel(t('Workflow state'))
         ->addConstraint('Length', ['max' => 128])
         ->setRequired(TRUE);
-
-      // workflow_debug(__FILE__, __FUNCTION__, __LINE__);  // @todo D8: test this snippet.
-      /*
-      $propertyDefinitions[$key]['workflow_transition'] = DataDefinition::create('any')
+    /*
+        $propertyDefinitions[$key]['workflow_transition'] = DataDefinition::create('any')
         //    $properties['workflow_transition'] = DataDefinition::create('WorkflowTransition')
         ->setLabel(t('Transition'))
         ->setDescription(t('The computed WorkflowItem object.'))
         ->setComputed(TRUE)
-        ->setClass('\Drupal\workflow\Entity\WorkflowTransition')
-        ->setSetting('date source', 'value');
-
-      $propertyDefinitions[$key]['display'] = array(
-        'type' => 'boolean',
-        'label' => t('Flag to control whether this file should be displayed when viewing content.'),
-      );
-      $propertyDefinitions[$key]['description'] = array(
-        'type' => 'string',
-        'label' => t('A description of the file.'),
-      );
-
-      $propertyDefinitions[$key]['display'] = array(
-        'type' => 'boolean',
-        'label' => t('Flag to control whether this file should be displayed when viewing content.'),
-      );
-      $propertyDefinitions[$key]['description'] = array(
-        'type' => 'string',
-        'label' => t('A description of the file.'),
-      );
-       */
+        ->setClass('\Drupal\workflow\Entity\WorkflowTransition');
+        // ->setSetting('date source', 'value');
+    */
     }
     return $propertyDefinitions[$key];
   }