task: #3636724 Use @webship-js/drupal-core-steps 2.1 for the webship-js suite and refresh the dependencies

Rajab Natshahrequested to merge
3636724-drupal-core-steps into 1.0.x

Summary

The Webship Starter functional tests (webship-js, Cucumber) now run on the public step pack @webship-js/drupal-core-steps (^2.1.0), so the login by handle is maintained in the pack instead of being copied into this project, and a test:dry script resolves every step of every scenario without a browser.

Issue: https://www.drupal.org/node/3636724

Changes

  • package.json: adds @webship-js/drupal-core-steps ^2.1.0 to the devDependencies, keeps webship-js on ^2.0.6 (the pack's peer range, now in its alphabetical place), drops the empty dependencies object and adds the test:dry script (cucumber-js --dry-run).
  • cucumber.js: adds the pack's step glob between the webship-js glob and the project's own, and puts the users registry in the pack's shape: username instead of name.
  • tests/step-definitions/webship.js: removes the custom I am a logged in user with ... user step. It matched the same sentences as the pack's login by handle, so each of those sentences matched two definitions. The project's other steps stay.

This project's pipeline installs Drupal from the recipe (the recipe job) and does not run the browser suite, so no CI job changes here. Node 24, Yarn 4.18.1 and DRUPAL_CORE: '11.4.x-dev' were already in place.

Test notes

Dry run (yarn test:dry) on Node 24.22.2 from a clean install of this branch, with no lock file: webship-js 2.0.6 and @webship-js/drupal-core-steps 2.1.0 resolve, and the run covers 23 scenarios and 147 steps, with none undefined and none ambiguous.

AI-Generated: Yes (configuration and step cleanup; reviewed by Rajab Natshah.)

Checkpoints:

  • File an issue
  • Addition/Change/Update/Fix
  • Testing to ensure no regression
  • Automated unit testing coverage
  • Automated functional testing coverage
  • UX/UI designer responsibilities
  • Readability
  • Accessibility
  • Performance
  • Security
  • Developer Documentation
  • User Guide Documentation
  • Reviewed by human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Release notes snippet
  • Release
Edited by Rajab Natshah

Merge request reports