Issue #3451400: Automated Drupal 11 compatibility fixes for webform_javascript_setting

.cspell-project-words.txt

+acquia
+Acquia
+perz
+ptid
+webform
+Webform

.gitlab-ci.yml

+################
+# GitLabCI template for Drupal projects.
+#
+# This template is designed to give any Contrib maintainer everything they need to test, without requiring modification.
+# It is also designed to keep up to date with Core Development automatically through the use of include files that can be centrally maintained.
+# As long as you include the project, ref and three files below, any future updates added by the Drupal Association will be used in your
+# pipelines automatically. However, you can modify this template if you have additional needs for your project.
+# The full documentation is on https://project.pages.drupalcode.org/gitlab_templates/
+################
+
+# For information on alternative values for 'ref' see https://project.pages.drupalcode.org/gitlab_templates/info/templates-version/
+# To test a Drupal 7 project, change the first include filename from .main.yml to .main-d7.yml
+include:
+  - project: $_GITLAB_TEMPLATES_REPO
+    ref: $_GITLAB_TEMPLATES_REF
+    file:
+      - '/includes/include.drupalci.main.yml'
+      - '/includes/include.drupalci.variables.yml'
+      - '/includes/include.drupalci.workflows.yml'
+#
+################
+# Pipeline configuration variables are defined with default values and descriptions in the file
+# https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes/include.drupalci.variables.yml
+# Uncomment the lines below if you want to override any of the variables. The following is just an example.
+################
+variables:
+  OPT_IN_TEST_CURRENT: '1'
+  OPT_IN_TEST_PREVIOUS_MAJOR: '1'
+  SKIP_ESLINT: '1'

composer.json

@@ -17,7 +17,7 @@
     "source": "https://git.drupalcode.org/project/webform_javascript_setting"
   },
   "require": {
-    "drupal/core": "^9.4 || ^10",
-    "drupal/webform": "^6.2"
+    "drupal/webform": "^6.2",
+    "drupal/core": "^9.4 || ^10 || ^11"
   }
 }

phpstan.neon

+includes:
+  - phar://phpstan.phar/conf/bleedingEdge.neon
+
+parameters:
+  level: 5
+  paths:
+    - .
+  reportUnmatchedIgnoredErrors: false
+  ignoreErrors:
+    # Required static call in /src/Plugin/WebformElement/WebformJavaScriptSetting.php
+    - "#Drupal calls should be avoided in classes, use dependency injection instead#"

src/Element/WebformJavaScriptSetting.php

@@ -5,7 +5,7 @@ namespace Drupal\webform_javascript_setting\Element;
 use Drupal\Core\Render\Element\Hidden;
 
 /**
- * Provides a webform element that stores a JavaScript setting in a hidden input.
+ * Adds a Webform element to store a JavaScript setting in a hidden input.
  *
  * @FormElement("webform_javascript_setting")
  */

tests/modules/webform_javascript_setting_test/webform_javascript_setting_test.info.yml

@@ -2,6 +2,6 @@ name: 'Webform JavaScript Settings Element test'
 type: module
 description: 'Support module for Webform JavaScript Settings Element testing.'
 package: 'Webform Testing'
-core_version_requirement: ^9.4
+core_version_requirement: ^9.4 || ^10.1 || ^11
 dependencies:
   - 'webform_javascript_setting:webform_javascript_setting'

tests/src/FunctionalJavascript/WebformJavaScriptSettingJavaScriptTest.php

@@ -23,7 +23,7 @@ class WebformJavaScriptSettingJavaScriptTest extends WebDriverTestBase {
   /**
    * Modules to enable.
    *
-   * @var array
+   * @var array<string>
    */
   protected static $modules = ['webform_javascript_setting_test'];
 

webform_javascript_setting.info.yml

@@ -2,6 +2,6 @@ name: 'Webform JavaScript Setting Element'
 description: 'Provides a webform element that pulls a JavaScript object''s setting/property into a hidden field.'
 package: Webform
 type: module
-core_version_requirement: ^9.4 || ^10
+core_version_requirement: ^9.4 || ^10 || ^11
 dependencies:
   - webform:webform

webform_javascript_setting.module

@@ -2,7 +2,7 @@
 
 /**
  * @file
- * Provides an element that pulls a JavaScript object''s setting into a hidden field.
+ * Adds a Webform element to store a JavaScript setting in a hidden input.
  */
 
 declare(strict_types=1);