Issue #3490266: Regression: Newest 3.2.x version uses vue.runtime.global.prod.js instead of vue.global.prod.js
1 unresolved thread
Closes #3490266
Merge request reports
Activity
143 * 144 * Introduced in https://www.drupal.org/project/vuejs/issues/3488596. 145 */ 146 function vuejs_update_93004(&$sandbox) { 147 $config_factory = \Drupal::configFactory(); 148 $config = $config_factory->getEditable('vuejs.settings'); 149 150 // Set the vue config: 151 $vueConfig = $config->get('vue'); 152 $vuePath = $vueConfig['path']; 153 154 if (str_contains($vuePath, 'vue.runtime.global.prod.js')) { 155 $vuePath = str_replace('vue.runtime.global.prod.js', 'vue.global.prod.js', $vuePath); 156 } 157 elseif (str_contains($vuePath, 'vue.global.prod.js') && version_compare($vueConfig['cdn_version'], '3.0.0', '<')) { 158 $vuePath = str_replace('vue.global.prod.js', 'vue.min.js', $vuePath); - Comment on lines +155 to +158
Two suggestions here:
- Only save and clear caches if we made a change
- If a change was detected, output a message what has been done for confirmation. You could do that in the return statement of the update hook.
Edited by Julian Pustkuchen changed this line in version 4 of the diff
Please register or sign in to reply