Skip to content
Snippets Groups Projects

Fix component ID for 10.3.

Closed Fix component ID for 10.3.
issue/vite-3448606:3448606-drupal-10.3-sdc into 1.x
1 unresolved thread
Closed mortona2k requested to merge issue/vite-3448606:3448606-drupal-10.3-sdc into 1.x
1 unresolved thread

Closes #3448606

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/Vite.php
44 44 foreach ($libraries as $libraryId => $library) {
45 45 $libraryExtension = $extension;
46 46 $isSdc = FALSE;
47 if ($extension === 'sdc') {
48 $componentExtension = explode('--', $libraryId)[0];
49 $libraryExtension = $componentExtension;
50 $isSdc = TRUE;
47 $prefix = 'components.';
48 $componentId = '';
49
50 if (str_starts_with($libraryId, $prefix)) {
51 if (substr($libraryId, 0, strlen($prefix)) == $prefix) {
  • wotnak
    wotnak @wotnak
    Maintainer

    The current approach in this MR has two main problems:

    • it breaks compatibility with drupal <10.3,
    • and every library whose id starts with components. is treated as a component library, while this is only true for libraries that are defined in the core/ namespace.
  • mortona2k added 7 commits

    added 7 commits

    Compare with previous version

  • mortona2k added 1 commit

    added 1 commit

    Compare with previous version

  • mortona2k added 1 commit

    added 1 commit

    Compare with previous version

  • wotnak
    wotnak @wotnak
    Maintainer

    Closing in favor of !14 (merged) which adds support for sdc in d10.3 without removing compatibility with earlier versions and adds documentation changes described in the issue summary.

  • wotnak closed

    closed

    • Please register or sign in to reply