Skip to content
Snippets Groups Projects

3162002-phpcs Drupal standards

Open 3162002-phpcs Drupal standards
issue/visualization-3162002:3162002-phpcs-drupal-standards into 8.x-1.x
13 unresolved threads
Open Rashmi requested to merge issue/visualization-3162002:3162002-phpcs-drupal-standards into 8.x-1.x
13 unresolved threads

Closes #3162002

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
js/highcharts.js
11 11 if (chart !== undefined) {
12 12 Drupal.visualization.charts[chart_id] = new Highcharts.Chart(chart.options);
13 13
14 Drupal.visualization.charts[chart_id].resize = function(width, height) {
15 this.setSize(width, height, false);
14 Drupal.visualization.charts[chart_id].resize = function (width, height) {
15 this.setSize(width, height, FALSE);
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on an old version of the diff
    • src/Form/VisualizationSettingsForm.php
    1 1 <?php
    2
    2 3 namespace Drupal\visualization\Form;
    3 4
    4 use Drupal\Core\Form\ConfigFormBase;
    5 5 use Drupal\Core\Config\ConfigFactory;
    6 use Symfony\Component\DependencyInjection\ContainerInterface;
    7 use Drupal\visualization\Plugin\VisualizationHandlerManager;
    6 use Drupal\Core\Form\ConfigFormBase;
    8 7 use Drupal\Core\Form\FormStateInterface;
    8 use Drupal\visualization\Plugin\VisualizationHandlerManager;
    9 use Symfony\Component\DependencyInjection\ContainerInterface;
    9 10
    11 /**
    12 * Visualization Settings Form.
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • src/Form/VisualizationSettingsForm.php
    18 22 $container->get('plugin.manager.visualization.handler'));
    19 23 }
    20 24
    25 /**
    26 * Constructs a new instance of the VisualizationSettingsForm class.
    27 *
    28 * @param \Drupal\Core\Config\ConfigFactory $config_factory
    29 * The configuration factory service.
    30 * @param \Drupal\visualization\Plugin\VisualizationHandlerManager $handler_manager
    31 * The visualization handler manager service.
    32 */
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • src/Form/VisualizationSettingsForm.php
    34 49 return ['visualization.settings'];
    35 50 }
    36 51
    52 /**
    53 * Build form.
    54 */
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on an old version of the diff
    • src/Plugin/views/style/Visualization.php
    162 164
    163 $form['yAxis']['title'] = array(
    165 $form['yAxis']['title'] = [
    164 166 '#type' => 'textfield',
    165 '#title' => t('Y-axis title'),
    167 '#title' => $this->t('Y-axis title'),
    166 168 '#default_value' => $this->options['yAxis']['title'],
    167 );
    169 ];
    168 170 }
    169 171
    170 172 /**
    171 173 * Adds sorting to the individual fields.
    172 174 */
    173 public function build_sort() {
    175 public function buildSort() {
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • src/Plugin/visualization/handler/GoogleVisualizationAPIHandler.php
    22 21 */
    23 22 class GoogleVisualizationAPIHandler implements VisualizationHandlerInterface {
    24 23
    24 /**
    25 * Name.
    26 *
    27 * @var name
    28 */
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on an old version of the diff
    • src/Plugin/visualization/handler/GoogleVisualizationAPIHandler.php
    22 21 */
    23 22 class GoogleVisualizationAPIHandler implements VisualizationHandlerInterface {
    24 23
    24 /**
    25 * Name.
    26 *
    27 * @var name
    28 */
    25 29 public $name = 'gva';
    26 30
    31 /**
    32 * Added javascript.
    33 *
    34 * @var addedJavascript
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on an old version of the diff
    • src/Plugin/visualization/handler/HighchartsHandler.php
    21 21 */
    22 22 class HighchartsHandler implements VisualizationHandlerInterface {
    23 23
    24 /**
    25 * The name of the visualization handler plugin.
    26 *
    27 * @var string
    28 * The name of the plugin, used to identify and load the handler.
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on an old version of the diff
    • src/Plugin/visualization/handler/HighchartsHandler.php
    21 21 */
    22 22 class HighchartsHandler implements VisualizationHandlerInterface {
    23 23
    24 /**
    25 * The name of the visualization handler plugin.
    26 *
    27 * @var string
    28 * The name of the plugin, used to identify and load the handler.
    29 */
    24 30 public $name = 'highcharts';
    25 31
    32 /**
    33 * Flag indicating whether the required JavaScript files have been added.
    34 *
    35 * @var bool
    36 * TRUE if the JavaScript files have been added, FALSE if not.
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on an old version of the diff
    • src/Plugin/visualization/handler/HighchartsHandler.php
    29 */
    24 30 public $name = 'highcharts';
    25 31
    32 /**
    33 * Flag indicating whether the required JavaScript files have been added.
    34 *
    35 * @var bool
    36 * TRUE if the JavaScript files have been added, FALSE if not.
    37 */
    26 38 protected $addedJavascript = FALSE;
    39
    40 /**
    41 * Flag indicating whether the visualization handler is available.
    42 *
    43 * @var bool
    44 * TRUE if the handler is available, FALSE if not.
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on an old version of the diff
    • src/Plugin/VisualizationHandlerManager.php
    1 1 <?php
    2 2
    3 namespace Drupal\visualization\Plugin;
    4
    3 5 /**
    4 * @file
    5 * Definition of Drupal\visualization\Plugin\VisualizationHandlerManager
    6 * Definition of Drupal\visualization\Plugin\VisualizationHandlerManager.
    6 7 */
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • visualization.api.php
    6 6 */
    7 7
    8 8 /**
    9 * Example page that demonstrates how to use the theme hook to visualize data
    10 * using the Visualization API. You can also use the Views display plugin if
    11 * you construct your data queries using Views.
    9 * Theme hook to visualize data using the Visualization API.
    10 */
    11
    12 /**
    13 * Example Views display plugin if you construct your data queries using Views.
    12 14 */
  • Alberto Paderno
    Alberto Paderno @avpaderno started a thread on the diff
    • visualization.module
    1 1 <?php
    2 2
    3 /**
    4 * @file
    5 * Visualization.
    6 */
    • Comment on lines +3 to +6
      Alberto Paderno
      Alberto Paderno @avpaderno

      The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the name of the module given in its .info.yml file.

    • Please register or sign in to reply
  • Sakthi Shanmuga Sundaram M added 1 commit

    added 1 commit

    Compare with previous version

  • Silvi Sanghavi added 1 commit

    added 1 commit

    Compare with previous version

  • Alberto Paderno added 1 commit

    added 1 commit

    Compare with previous version

    • Please register or sign in to reply