fix: #3608377 Restore the Vartheme Claro theme hook delegation shims

Rajab Natshahrequested to merge
issue/vartheme_claro-3608377:3608377-restore-theme-shims into 3.1.x

Restores vartheme_claro.theme — reverts the shim removal merged from the previous MR. Drupal's object-oriented hook attribute discovery (HookCollectorPass) collects #[Hook] classes from modules only; themes are not scanned, so the procedural .theme delegation functions are the actual invocation mechanism for the theme's hooks. Removing them silently disabled every hook of the theme (caught at runtime by the vartheme_bs5 browser test suite in vartheme_bs5!186 (merged)). The hook logic stays in the OOP class; the restored file's docblock now documents why the shims must stay until core supports attribute hooks in themes.

Related issue: #3608377

This changeset was produced with AI assistance (Claude Code). Per the Drupal AI-generated contribution policy, it has been reviewed by a human before submission.

Checkpoints

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Reviewed by a human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes
  • Release

Merge request reports