fix: #3625415 Make the icon toggle scrim a plain element, not a hidden button

Rajab Natshahrequested to merge
issue/vartheme_bs5_rightup-3625415:3625415-make-the-icon into 1.0.x

The icon toggle scrim is now a div with aria-hidden="true" instead of a hidden button, and the button resets are dropped from the SCSS (CSS rebuilt). icon-toggle.js binds by class and is unchanged.

Checked anonymous at 1440 and 375 on a fresh RightUp site: a click outside the panel closes it and returns focus to the toggle, Escape closes it, no overflow, 0 console errors.

Closes #3625415.

AI-Generated: Yes

Checkpoints:

  • File an issue
  • Addition/Change/Update/Fix
  • Testing to ensure no regression
  • Automated unit testing coverage
  • Automated functional testing coverage
  • UX/UI designer responsibilities
  • Readability
  • Accessibility
  • Performance
  • Security
  • Developer Documentation
  • User Guide Documentation
  • Reviewed by human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Release notes snippet
  • Release

🤖 Generated with Claude Code

Edited by Rajab Natshah

Merge request reports