fix: #3625591 Render the page title as the h1 on the 404 and 403 pages

Rajab Natshahrequested to merge
issue/vartheme_bs5_horizonaid-3625591:3625591-404-403-h1 into 1.0.x

Closes #3625591

What changed

  • Canvas page regions render the page without the page title block, so the default 404, 403 and 401 pages had no h1. The theme now adds the page title to the content region on those routes, only when no page title block is already there.
  • The page-title component passed an empty text_size to heading, whose enum has no empty value. It now passes it only when set.

Testing

On a Horizon Aid 1.0.4 site: /this-page-does-not-exist and /admin (logged out, default 403 page) each render one h1 and axe reports no violations. Home, Countries, Search and one node of every content type still have exactly one h1.

AI-Generated: Yes

Checkpoints

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Reviewed by a human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes and Update Helper on new feature change/addition
  • Release
Edited by Rajab Natshah

Merge request reports