Skip to content
Snippets Groups Projects

Issue #3446774 by n.ghunaim: Style the Sitewide Alert to follow with Bootstrap ~5.3.0 and Varbase Design System

Merged Issue #3446774 by n.ghunaim: Style the Sitewide Alert to follow with Bootstrap ~5.3.0 and Varbase Design System
1 unresolved thread
Merged Noor Ghunaim requested to merge issue/vartheme_bs5-3446774:3446774-style-the-sitewide into 3.0.x
1 unresolved thread

Remaining tasks

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Code review from 1 Varbase core team member
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes and Update Helper on new feature change/addition
  • Release

Related to #3446774

Edited by Rajab Natshah

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
123 123 $language_direction = $language->getDirection();
124 124 $variables['lang_dir'] = $language_direction;
125 125 }
126
127 /**
128 * Implements hook_library_info_alter().
129 */
130 function vartheme_bs5_library_info_alter(array &$libraries, $module) {
131 if ($module === 'sitewide_alert' && isset($libraries['init'])) {
132 // Add the dependency only if it's not already present.
133 if (!in_array('varbase_components/bs-alert-style', $libraries['init']['dependencies'])) {
134 $libraries['init']['dependencies'][] = 'varbase_components/bs-alert-style';
135 }
136 unset($libraries['init']['css']);
137 }
138 }
    • For sure we need to define the "vartheme_bs5/bs-alert-style" in the theme -> "It could be commented"
    • Override the library by varbase_components/bs-alert-style: vartheme_bs5/bs-alert-style -> "It could be commented too"
  • Rajab Natshah changed title from Resolve #3446774 "Style the sitewide" to Issue #3446774 by n.ghunaim: Style the Sitewide Alert to follow with Bootstrap ~5.3.0 and Varbase Design System

    changed title from Resolve #3446774 "Style the sitewide" to Issue #3446774 by n.ghunaim: Style the Sitewide Alert to follow with Bootstrap ~5.3.0 and Varbase Design System

  • looking for an easier update path. Maybe only by one action copy of the sitewide-alert.html.twig file into old custom themes in projects

  • Noor Ghunaim added 1 commit

    added 1 commit

    Compare with previous version

  • Noor Ghunaim added 1 commit

    added 1 commit

    • 1579a538 - Update vartheme_bs5.libraries.yml

    Compare with previous version

  • Noor Ghunaim added 1 commit

    added 1 commit

    • 32e6cc1e - Update vartheme_bs5.info.yml

    Compare with previous version

  • Author Contributor

    I moved the hook_library_info_alter to Varbase components module, and created a new bs-alert-style library for vartheme_bs5 with override, do you think we need to move the alert.css file to vartheme_bs5 too?

  • Looking good up to this point When a developer creates a new cloned generated theme for a project it will be copied Customize a Varbase Single Directory Components (SDC) In a Custom Theme They can uncomment to custom the style of sitewide alert. But default alert styles dose not change much in projects.

    In Creating Your Own Theme We recently added Copy All Varbase Components to the New Custom Theme


    working on Issue #3442844: Add a new varbase:generate-theme Drush command to create new Vartheme BS5 Cloned Generated Theme with a copy of all Varbase Components

    Edited by Rajab Natshah
  • Rajab Natshah marked the checklist item Code review from 1 Varbase core team member as completed

    marked the checklist item Code review from 1 Varbase core team member as completed

  • Rajab Natshah marked the checklist item Credit contributors as completed

    marked the checklist item Credit contributors as completed

  • Rajab Natshah marked the checklist item Testing to ensure no regression as completed

    marked the checklist item Testing to ensure no regression as completed

  • Noor Ghunaim added 1 commit

    added 1 commit

    • 01287060 - Update vartheme_bs5.libraries.yml

    Compare with previous version

  • Noor Ghunaim added 1 commit

    added 1 commit

    • 2f730cae - Update vartheme_bs5.info.yml

    Compare with previous version

  • Please register or sign in to reply
    Loading