fix: #3610057 Make the Hero Card SDC Canvas-eligible on Drupal 11.4 (valid button_1_url example)

Rajab Natshahrequested to merge
issue/vartheme_bs5-3610057:3610057-hero-card-canvas-eligible into 5.0.x

On Drupal 11.4, Drupal Canvas validates every SDC prop's examples value against its declared format. The Hero Card SDC (components/organisms/card-hero/card-hero.component.yml) has a button_1_url prop with format: uri-reference whose examples value was "#", which fails uri-reference validation ("Invalid URL format"). Canvas therefore marked the whole Hero Card component INELIGIBLE, so it disappeared from the Canvas component library — breaking the varbase_project functional test 09-04-canvas-hero-cards.feature.

This one-line fix changes the button_1_url prop's examples value from "#" to "https://example.com" (a valid absolute URL), so it passes uri-reference validation. The default: "#" value is left unchanged.

This exact change was already made in commit 01e784c2 on the vartheme_bs5 issue fork branch 3607734-update-drupal-core, but it landed after the #3607734 MR had already merged, so it never reached canonical 5.0.x. This MR lands it on canonical 5.0.x via a dedicated issue.

Issue: https://www.drupal.org/project/vartheme_bs5/issues/3610057

AI-Generated: Yes (one-line SDC example fix; reviewed by Rajab Natshah.)

Checkpoints

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Reviewed by a human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes
  • Release
Edited by Rajab Natshah

Merge request reports