chore: #3621019 Remove the Varbase Dev Base dependency from the Varbase Starter recipe composer.json

Rajab Natshahrequested to merge
issue/varbase_starter-3621019:3621019-remove-the-varbase into 1.0.x

Issue: https://www.drupal.org/project/varbase_starter/issues/3621019 Pair issue: https://www.drupal.org/project/varbase_project/issues/3621020

What changed

One line removed from require in composer.json:

"drupal/varbase_dev_base": "~1.0.0",

Nothing else. The JSON is unchanged apart from that deletion.

Why

Varbase Starter is a site-template recipe, and it does not apply Varbase Dev Base. Requiring it here pulls a development stack (devel, storybook, reroute_email, stage_file_proxy, devel_entity_updates) into the dependency tree of every site that composes Varbase Starter, for a recipe the template never applies.

The development stack belongs in the project template, not in the site-template recipe. That is the pair issue, #3621020, which adds it to the Varbase Project Template.

Commit type

chore: rather than fix:. Nothing was behaving incorrectly; this removes a dependency that was never used. If a maintainer prefers fix: because the unused requirement had a real cost (shipping a dev stack to production sites), that is a reasonable reading and the commit can be re-worded on request.

Verification actually performed

  • composer.json still parses as valid JSON after the deletion (no trailing-comma breakage).
  • The recipe never applies it: recipes: in recipe.yml has 25 entries, and varbase_dev_base is not among them.
  • CI is unaffected. .gitlab-ci.yml around line 340 already composer requires varbase_dev_base into the test host itself, under the comment that Starter deliberately does not compose these stacks; and the recipe-apply loop around line 365 is self-contained. So the test job does not depend on this line being in composer.json.

NOT tested

  • No composer update or lock regeneration was run locally, and no install was performed. The pipeline on this MR is the first real resolution test.

Open question for the maintainer

tests/README.md mentions varbase_dev_base. I have deliberately not changed that line — whether the doc needs updating alongside this removal is a maintainer call, not something to slip into this MR silently.

AI policy

AI-Generated: Yes

Checkpoints:

  • File an issue
  • Addition/Change/Update/Fix
  • Testing to ensure no regression
  • Automated unit testing coverage
  • Automated functional testing coverage
  • UX/UI designer responsibilities
  • Readability
  • Accessibility
  • Performance
  • Security
  • Developer Documentation
  • User Guide Documentation
  • Reviewed by human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Release notes snippet
  • Release
Edited by Rajab Natshah

Merge request reports