refactor: #3618246 Remove the Drupal CMS wiring script and inline the wiring in CI

Rajab Natshahrequested to merge
issue/varbase_starter-3618246:3618246-remove-drupal-cms-wiring into 1.0.x

Related issue: #3618246

Follow-up to MR !30 (merged) (merged): now that vardot/varbase-patches no longer lives in the recipe's composer.json, remove the Drupal CMS wiring script and its Composer/npm assets from the recipe and reproduce that wiring inline in CI, where it is actually exercised. A drupal-recipe should not ship a bespoke PHP wiring script or a committed lockfile.

What

Remove the Drupal CMS wiring script + assets and the committed yarn.lock; move the wiring into the 🧩 (Drupal CMS) Install CI job. The reusable scripts/drupal-libraries-sync.js stays in the recipe.

Changes

  • Delete scripts/drupal-cms-wiring.php, scripts/assets/drupal-cms.composer.json, scripts/assets/drupal-libraries.package.json, and the committed yarn.lock.
  • Keep scripts/drupal-libraries-sync.js (still shipped by the recipe).
  • .gitlab-ci.yml: the 🧩 (Drupal CMS) Install job no longer calls php scripts/drupal-cms-wiring.php; it now wires the Drupal CMS root inline — composer config for minimum-stability/prefer-stable, the three allow-plugins, the patches config + allowlist, require vardot/varbase-patches:~11.0.0, writes .yarnrc.yml, merges the drupal-libraries block into package.json, and copies the recipe's scripts/drupal-libraries-sync.js into the build.
  • scripts/README.md: drop the "Wire a Drupal CMS project" section.

Testing

Local green-gate (gitlab-ci-local, this branch's tree): Composer validate, YAML lint, Cspell, ESLint, Cucumber dry-run all pass. The 🧩 (Drupal CMS) Install, Varbase install and varbase-e2e matrix are full-build/browser jobs that only run on the remote pipeline; the inline wiring is verified there.

AI-Generated: Yes

Checkpoints:

  • File an issue
  • Addition/Change/Update/Fix
  • Testing to ensure no regression
  • Automated unit testing coverage
  • Automated functional testing coverage
  • UX/UI designer responsibilities
  • Readability
  • Accessibility
  • Performance
  • Security
  • Developer Documentation
  • User Guide Documentation
  • Reviewed by human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Release notes snippet
  • Release
Edited by Rajab Natshah

Merge request reports