fix: #3611208 ddev init-full-automated-testing skips the testing users (add-testing-users not on the container PATH)

Rajab Natshahrequested to merge
issue/varbase_project-3611208:3611208-fix-ddev-init-full-automated-testing into 10.1.x

Closes issue: https://www.drupal.org/project/varbase_project/issues/3611208

Summary

ddev init-full-automated-testing on the Varbase Project Template 10.1.x skipped the automated-testing users on a fresh DDEV environment.

The script called the sibling add-testing-users ddev web command as a bare name, but sibling ddev web commands are not on PATH inside the web container. Guarded with || true, the call failed silently, so none of the 6 per-role testing users (Editor/Content admin/SEO admin/Site admin/Super admin/Normal) were ever created.

Fix

.ddev/commands/web/init-full-automated-testing: the fix now mirrors the 11.0.x branch — it inlines the testing-user creation loop (sourcing bash-yaml + varbase.users.yml) directly in the script, instead of calling the sibling add-testing-users ddev web command, which isn't on the container PATH. This keeps 10.1.x consistent with how 11.0.x already manages init-full-automated-testing.

Scope change

This MR previously also carried a set -e tolerance workaround for a non-fatal oEmbed fetch failure during drush site:install. That workaround has been dropped: the oEmbed abort was root-caused to the dead Vimeo demo video in varbase_media_demo, which is now fixed upstream and released as varbase_media_demo 10.1.1. With that fixed at the source, init-full-automated-testing no longer needs any oEmbed tolerance — set -e fail-fast is correct again, and the install block is back to its original fail-fast form (no || true, no bootstrap re-check gate).

The only remaining fix in this MR is inlining the testing-user creation loop, to mirror 11.0.x.

Verified result

ddev init-full-automated-testing completes in one shot (EXIT=0) with all 6 testing users + 5 role assignments applied.

AI-Generated: Yes (Used Claude Code to diagnose and fix the DDEV install script, and to align it with how 11.0.x already manages init-full-automated-testing; reviewed by Natshah.)

Checkpoints

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Reviewed by a human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes
  • Release
Edited by Rajab Natshah

Merge request reports